From 687cb8f5e7cd9316eeeab6dc4821de5bdb1947b4 Mon Sep 17 00:00:00 2001 From: "putterman%netscape.com" Date: Thu, 18 Mar 1999 21:40:12 +0000 Subject: [PATCH] Changes made to avoid nsMsgHdr duplication. Add back releases so memory management works correctly. git-svn-id: svn://10.0.0.236/trunk@24338 18797224-902f-48f8-a5cc-f745e15eee43 --- mozilla/mailnews/local/src/nsMailboxProtocol.cpp | 3 +-- mozilla/mailnews/local/src/nsParseMailbox.cpp | 6 ++---- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/mozilla/mailnews/local/src/nsMailboxProtocol.cpp b/mozilla/mailnews/local/src/nsMailboxProtocol.cpp index 903e9c06019..07326970aa2 100644 --- a/mozilla/mailnews/local/src/nsMailboxProtocol.cpp +++ b/mozilla/mailnews/local/src/nsMailboxProtocol.cpp @@ -327,8 +327,7 @@ PRInt32 nsMailboxProtocol::SetupReadMessage() if (msgHdr) { msgHdr->GetMessageSize(&messageSize); - //XXXXX Don't release until we fix the nsMsgHdr RDF problem. -// msgHdr->Release(); + msgHdr->Release(); } mailDb->Close(PR_TRUE); } diff --git a/mozilla/mailnews/local/src/nsParseMailbox.cpp b/mozilla/mailnews/local/src/nsParseMailbox.cpp index 8e274bac5b9..2c771841e75 100644 --- a/mozilla/mailnews/local/src/nsParseMailbox.cpp +++ b/mozilla/mailnews/local/src/nsParseMailbox.cpp @@ -109,8 +109,7 @@ NS_IMETHODIMP nsMsgMailboxParser::OnStopBinding(nsIURL* aURL, nsresult aStatus, printf("hdr key = %ld, author = %s subject = %s\n", key, (authorStr) ? authorStr : "", (subjectStr) ? subjectStr : ""); delete [] authorStr; delete [] subjectStr; - //Once again this is part of the problem caused by the RDF/nsMsgHdr problem. - //msgHdr->Release(); + msgHdr->Release(); } } m_mailDB->Close(TRUE); @@ -268,8 +267,7 @@ PRInt32 nsMsgMailboxParser::PublishMsgHeader() else if (m_mailDB != NULL) { m_mailDB->AddNewHdrToDB(m_newMsgHdr, m_updateAsWeGo); - //XXXX this needs to be put back in when we fix nsMsgHdr rdf dependency. - // m_newMsgHdr->Release(); + m_newMsgHdr->Release(); // should we release here? m_newMsgHdr = NULL; }