Bommels05/Mozilla
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

bug: http://bugzilla.mozilla.org/show_bug.cgi?id=34665

Browse Source 
This change replaces all printfs in src_moz with calls to PR_LOG.  No
printfs should appear in src_moz anymore.

You won't see any console output from native code unless you define

NSPR_LOG_MODULES=webclient:3

in your environment.  Furthermore, if you want PR_LOG statements in
webclient to go to a file instead, define

WEBCLIENT_LOG_FILE=C:\VALIDDIR\filename.txt

in your environment.  This file will get created fresh each time, since
PR_LOG uses fopen(filename, "w").

New Files:

I've created ns_globals.h, included from jni_util.h.  ns_globals.h holds
an extern * to a struct used in the PR_LOG calls.

Significant changes:

WrapperFactoryImpl.cpp

nativeAppInitialize(){

Added:

#if DEBUG_RAPTOR_CANVAS
    prLogModuleInfo = PR_NewLogModule("webclient");
    const char *webclientLogFile = PR_GetEnv("WEBCLIENT_LOG_FILE");
    if (nsnull != webclientLogFile) {
        PR_SetLogFile(webclientLogFile);
        // If this fails, it just goes to stdout/stderr
    }
#endif
}

All the other files in this checkin follow the this pattern:

Before checkin:

       printf("InitMozillaStuff(%lx): Create the Event Queue for the UI thread...\n",
               initContext);

After checkin:

    if (prLogModuleInfo) {
        PR_LOG(prLogModuleInfo, 3,
               ("InitMozillaStuff(%lx): Create the Event Queue for the UI thread...\n",
               initContext));
    }

See http://lxr.mozilla.org/mozilla/source/nsprpub/pr/include/prlog.h#190

for the definition of PR_LOG


git-svn-id: svn://10.0.0.236/trunk@65380 18797224-902f-48f8-a5cc-f745e15eee43
This commit is contained in:
edburns%acm.org
2000-04-05 21:38:27 +00:00
parent e095d84ccd
commit 6bd98defd0
14 changed files with 311 additions and 193 deletions
Download Patch File Download Diff File Expand all files Collapse all files

33
mozilla/java/webclient/src_moz/jni_util.cpp
View File

@@ -27,7 +27,8 @@
#include "jni_util.h"
JavaVM *gVm = nsnull;
JavaVM *gVm = nsnull; // declared in ns_globals.h, which is included in
// jni_util.h
void util_ThrowExceptionToJava (JNIEnv * env, const char * message)
{
@@ -113,7 +114,10 @@ void util_SendEventToJava(JNIEnv *yourEnv, jobject nativeEventThread,
env->CallVoidMethod(nativeEventThread, mid, webclientEventListener,
eventType);
} else {
printf("cannot call the Java Method!\n");
if (prLogModuleInfo) {
PR_LOG(prLogModuleInfo, 3,
("cannot call the Java Method!\n"));
}
}
}
@@ -293,13 +297,19 @@ jint util_GetIntValueFromInstance(JNIEnv *env, jobject obj,
#else
jclass objClass = env->GetObjectClass(obj);
if (nsnull == objClass) {
printf("util_GetIntValueFromInstance: Can't get object class from instance.\n");
if (prLogModuleInfo) {
PR_LOG(prLogModuleInfo, 3,
("util_GetIntValueFromInstance: Can't get object class from instance.\n"));
}
return result;
}
jfieldID theFieldID = env->GetFieldID(objClass, fieldName, "I");
if (nsnull == theFieldID) {
printf("util_GetIntValueFromInstance: Can't get fieldID for fieldName.\n");
if (prLogModuleInfo) {
PR_LOG(prLogModuleInfo, 3,
("util_GetIntValueFromInstance: Can't get fieldID for fieldName.\n"));
}
return result;
}
@@ -315,13 +325,19 @@ void util_SetIntValueForInstance(JNIEnv *env, jobject obj,
#else
jclass objClass = env->GetObjectClass(obj);
if (nsnull == objClass) {
printf("util_SetIntValueForInstance: Can't get object class from instance.\n");
if (prLogModuleInfo) {
PR_LOG(prLogModuleInfo, 3,
("util_SetIntValueForInstance: Can't get object class from instance.\n"));
}
return;
}
jfieldID fieldID = env->GetFieldID(objClass, fieldName, "I");
if (nsnull == fieldID) {
printf("util_SetIntValueForInstance: Can't get fieldID for fieldName.\n");
if (prLogModuleInfo) {
PR_LOG(prLogModuleInfo, 3,
("util_SetIntValueForInstance: Can't get fieldID for fieldName.\n"));
}
return;
}
@@ -362,7 +378,6 @@ JNU_CallMethodByNameV(JNIEnv *env,
jmethodID mid;
jvalue result;
const char *p = signature;
printf("jni_util: call method by name if 0");
/* find out the return type */
while (*p && *p != ')')
p++;
@@ -372,14 +387,10 @@ JNU_CallMethodByNameV(JNIEnv *env,
if (env->EnsureLocalCapacity(3) < 0)
goto done2;
printf("jni_util: call method by name if 1");
clazz = env->GetObjectClass(obj);
printf("jni_util: call method by name 2");
mid = env->GetMethodID(clazz, name, signature);
printf("jni_util: call method by name 3");
if (mid == 0)
goto done1;
printf("jni_util: call method by name if 4");
switch (*p) {
case 'V':
env->CallVoidMethodV(obj, mid, args);