From 6c79d9aa88e95dd321256ecc3fd416a6374ef721 Mon Sep 17 00:00:00 2001 From: "bzrmirror%bugzilla.org" Date: Sun, 23 Mar 2014 01:16:00 +0000 Subject: [PATCH] Bug 962812: Use the "required" attribute where appropriate r=LpSolit a=justdave git-svn-id: svn://10.0.0.236/trunk@265298 18797224-902f-48f8-a5cc-f745e15eee43 --- mozilla/webtools/bugzilla/.bzrrev | 2 +- mozilla/webtools/bugzilla/.gitrev | 2 +- .../template/en/default/account/auth/login.html.tmpl | 6 +++--- .../bugzilla/template/en/default/account/create.html.tmpl | 2 +- .../en/default/account/email/confirm-new.html.tmpl | 4 ++-- .../template/en/default/account/email/confirm.html.tmpl | 2 +- .../account/password/set-forgotten-password.html.tmpl | 6 +++--- .../default/admin/classifications/edit-common.html.tmpl | 2 +- .../en/default/admin/components/edit-common.html.tmpl | 4 +++- .../en/default/admin/custom_fields/edit-common.html.tmpl | 4 ++-- .../en/default/admin/fieldvalues/create.html.tmpl | 2 +- .../template/en/default/admin/fieldvalues/edit.html.tmpl | 2 +- .../template/en/default/admin/flag-type/edit.html.tmpl | 5 +++-- .../template/en/default/admin/groups/create.html.tmpl | 4 ++-- .../template/en/default/admin/groups/edit.html.tmpl | 4 ++-- .../template/en/default/admin/keywords/create.html.tmpl | 3 ++- .../template/en/default/admin/keywords/edit.html.tmpl | 3 ++- .../template/en/default/admin/milestones/create.html.tmpl | 2 +- .../template/en/default/admin/milestones/edit.html.tmpl | 2 +- .../template/en/default/admin/products/create.html.tmpl | 2 +- .../en/default/admin/products/edit-common.html.tmpl | 4 ++-- .../bugzilla/template/en/default/admin/sudo.html.tmpl | 3 ++- .../template/en/default/admin/users/userdata.html.tmpl | 4 ++-- .../template/en/default/admin/versions/create.html.tmpl | 2 +- .../template/en/default/admin/versions/edit.html.tmpl | 2 +- .../bugzilla/template/en/default/bug/field.html.tmpl | 8 ++++---- .../template/en/default/global/userselect.html.tmpl | 3 +++ .../bugzilla/template/en/default/list/quips.html.tmpl | 2 +- 28 files changed, 50 insertions(+), 41 deletions(-) diff --git a/mozilla/webtools/bugzilla/.bzrrev b/mozilla/webtools/bugzilla/.bzrrev index 98a67476411..2036146d03a 100644 --- a/mozilla/webtools/bugzilla/.bzrrev +++ b/mozilla/webtools/bugzilla/.bzrrev @@ -1 +1 @@ -8965 \ No newline at end of file +8966 \ No newline at end of file diff --git a/mozilla/webtools/bugzilla/.gitrev b/mozilla/webtools/bugzilla/.gitrev index 6e1bc54c75a..1b3afa1af06 100644 --- a/mozilla/webtools/bugzilla/.gitrev +++ b/mozilla/webtools/bugzilla/.gitrev @@ -1 +1 @@ -d9cd47075697a363b94c575526937ad40c617a0b \ No newline at end of file +165689a71928008f2d12f9cd8228497594899c2f \ No newline at end of file diff --git a/mozilla/webtools/bugzilla/template/en/default/account/auth/login.html.tmpl b/mozilla/webtools/bugzilla/template/en/default/account/auth/login.html.tmpl index 27c0690af5f..bf20edb8b51 100644 --- a/mozilla/webtools/bugzilla/template/en/default/account/auth/login.html.tmpl +++ b/mozilla/webtools/bugzilla/template/en/default/account/auth/login.html.tmpl @@ -39,14 +39,14 @@ + [%- ' type="email"' UNLESS Param('emailsuffix') %] autofocus required> [% Param('emailsuffix') FILTER html %] - + @@ -115,7 +115,7 @@ If you have an account, but have forgotten your password, enter your login name below and submit a request to change your password.
- + diff --git a/mozilla/webtools/bugzilla/template/en/default/account/create.html.tmpl b/mozilla/webtools/bugzilla/template/en/default/account/create.html.tmpl index 1b5a4daa8d5..5711a726f3b 100644 --- a/mozilla/webtools/bugzilla/template/en/default/account/create.html.tmpl +++ b/mozilla/webtools/bugzilla/template/en/default/account/create.html.tmpl @@ -72,7 +72,7 @@ [% END %] + [%- ' type="email"' UNLESS Param('emailsuffix') %] required> [% Param('emailsuffix') FILTER html %] diff --git a/mozilla/webtools/bugzilla/template/en/default/account/email/confirm-new.html.tmpl b/mozilla/webtools/bugzilla/template/en/default/account/email/confirm-new.html.tmpl index ec8d5a47436..09509769884 100644 --- a/mozilla/webtools/bugzilla/template/en/default/account/email/confirm-new.html.tmpl +++ b/mozilla/webtools/bugzilla/template/en/default/account/email/confirm-new.html.tmpl @@ -38,13 +38,13 @@ : - + (minimum [% constants.USER_PASSWORD_MIN_LENGTH FILTER none %] characters) : - +   diff --git a/mozilla/webtools/bugzilla/template/en/default/account/email/confirm.html.tmpl b/mozilla/webtools/bugzilla/template/en/default/account/email/confirm.html.tmpl index 6fc17187839..8edc7a9badf 100644 --- a/mozilla/webtools/bugzilla/template/en/default/account/email/confirm.html.tmpl +++ b/mozilla/webtools/bugzilla/template/en/default/account/email/confirm.html.tmpl @@ -23,7 +23,7 @@ - + diff --git a/mozilla/webtools/bugzilla/template/en/default/account/password/set-forgotten-password.html.tmpl b/mozilla/webtools/bugzilla/template/en/default/account/password/set-forgotten-password.html.tmpl index b203e66e9b4..eca11174f3d 100644 --- a/mozilla/webtools/bugzilla/template/en/default/account/password/set-forgotten-password.html.tmpl +++ b/mozilla/webtools/bugzilla/template/en/default/account/password/set-forgotten-password.html.tmpl @@ -30,17 +30,17 @@ - + + value="[% classification.name FILTER html %]" required> diff --git a/mozilla/webtools/bugzilla/template/en/default/admin/components/edit-common.html.tmpl b/mozilla/webtools/bugzilla/template/en/default/admin/components/edit-common.html.tmpl index 00b80baa8d4..72300af79ca 100644 --- a/mozilla/webtools/bugzilla/template/en/default/admin/components/edit-common.html.tmpl +++ b/mozilla/webtools/bugzilla/template/en/default/admin/components/edit-common.html.tmpl @@ -17,7 +17,7 @@ + value="[%- comp.name FILTER html %]" required> @@ -29,6 +29,7 @@ cols = 64 wrap = 'virtual' defaultcontent = comp.description + mandatory = 1 %] @@ -40,6 +41,7 @@ id => "initialowner" value => comp.default_assignee.login size => 64 + mandatory => 1 %] diff --git a/mozilla/webtools/bugzilla/template/en/default/admin/custom_fields/edit-common.html.tmpl b/mozilla/webtools/bugzilla/template/en/default/admin/custom_fields/edit-common.html.tmpl index f54073cfe8c..6c22bb81fd9 100644 --- a/mozilla/webtools/bugzilla/template/en/default/admin/custom_fields/edit-common.html.tmpl +++ b/mozilla/webtools/bugzilla/template/en/default/admin/custom_fields/edit-common.html.tmpl @@ -19,7 +19,7 @@ [% IF field %] [% field.name FILTER html %] [% ELSE %] - + [% END %] @@ -37,7 +37,7 @@ diff --git a/mozilla/webtools/bugzilla/template/en/default/admin/fieldvalues/edit.html.tmpl b/mozilla/webtools/bugzilla/template/en/default/admin/fieldvalues/edit.html.tmpl index dbe222590b7..2630fee9244 100644 --- a/mozilla/webtools/bugzilla/template/en/default/admin/fieldvalues/edit.html.tmpl +++ b/mozilla/webtools/bugzilla/template/en/default/admin/fieldvalues/edit.html.tmpl @@ -32,7 +32,7 @@ [% ELSE %] + value="[% value.name FILTER html %]" required> [% END %] diff --git a/mozilla/webtools/bugzilla/template/en/default/admin/flag-type/edit.html.tmpl b/mozilla/webtools/bugzilla/template/en/default/admin/flag-type/edit.html.tmpl index e52d58a9a5d..4ee4a999ca1 100644 --- a/mozilla/webtools/bugzilla/template/en/default/admin/flag-type/edit.html.tmpl +++ b/mozilla/webtools/bugzilla/template/en/default/admin/flag-type/edit.html.tmpl @@ -52,7 +52,7 @@ @@ -66,6 +66,7 @@ cols = 80 defaultcontent = type.description disabled = !can_fully_edit + mandatory = 1 %] @@ -129,7 +130,7 @@ don't care what order the types appear in or if you want them to appear in alphabetical order.
+ maxlength="5" [% ' disabled="disabled"' UNLESS can_fully_edit %] required> diff --git a/mozilla/webtools/bugzilla/template/en/default/admin/groups/create.html.tmpl b/mozilla/webtools/bugzilla/template/en/default/admin/groups/create.html.tmpl index 06396926cdf..8f9be1c7a30 100644 --- a/mozilla/webtools/bugzilla/template/en/default/admin/groups/create.html.tmpl +++ b/mozilla/webtools/bugzilla/template/en/default/admin/groups/create.html.tmpl @@ -21,11 +21,11 @@
Password:
 
New password: - +
Confirm new password: - +
  diff --git a/mozilla/webtools/bugzilla/template/en/default/admin/classifications/edit-common.html.tmpl b/mozilla/webtools/bugzilla/template/en/default/admin/classifications/edit-common.html.tmpl index 9dd6c1676b1..c2bae5c4293 100644 --- a/mozilla/webtools/bugzilla/template/en/default/admin/classifications/edit-common.html.tmpl +++ b/mozilla/webtools/bugzilla/template/en/default/admin/classifications/edit-common.html.tmpl @@ -13,7 +13,7 @@
Classification:
Description:
+ value="[% field.description FILTER html %]" required> diff --git a/mozilla/webtools/bugzilla/template/en/default/admin/fieldvalues/create.html.tmpl b/mozilla/webtools/bugzilla/template/en/default/admin/fieldvalues/create.html.tmpl index 4d07d5b0eb8..8d1dbc8b977 100644 --- a/mozilla/webtools/bugzilla/template/en/default/admin/fieldvalues/create.html.tmpl +++ b/mozilla/webtools/bugzilla/template/en/default/admin/fieldvalues/create.html.tmpl @@ -29,7 +29,7 @@ + maxlength="[% constants.MAX_FIELD_VALUE_SIZE FILTER none %]" required>
a short name identifying this type.
+ maxlength="50" [%- ' disabled="disabled"' UNLESS can_fully_edit %] required>
- + - + diff --git a/mozilla/webtools/bugzilla/template/en/default/admin/groups/edit.html.tmpl b/mozilla/webtools/bugzilla/template/en/default/admin/groups/edit.html.tmpl index c9883ce42da..1cc948ea243 100644 --- a/mozilla/webtools/bugzilla/template/en/default/admin/groups/edit.html.tmpl +++ b/mozilla/webtools/bugzilla/template/en/default/admin/groups/edit.html.tmpl @@ -32,7 +32,7 @@ diff --git a/mozilla/webtools/bugzilla/template/en/default/bug/field.html.tmpl b/mozilla/webtools/bugzilla/template/en/default/bug/field.html.tmpl index b3b92e19828..88200fdfa18 100644 --- a/mozilla/webtools/bugzilla/template/en/default/bug/field.html.tmpl +++ b/mozilla/webtools/bugzilla/template/en/default/bug/field.html.tmpl @@ -42,13 +42,13 @@ value="[% value FILTER html %]" size="40" maxlength="[% constants.MAX_FREETEXT_LENGTH FILTER none %]" [% ' pattern="\d+"' IF field.type == constants.FIELD_TYPE_INTEGER %] - [% ' aria-required="true"' IF field.is_mandatory %]> + [% ' aria-required="true" required' IF field.is_mandatory %]> [% CASE [constants.FIELD_TYPE_DATETIME, constants.FIELD_TYPE_DATE] %] [% size = (field.type == constants.FIELD_TYPE_DATE) ? 10 : 20 %]
Group Name:
Description:
User Regexp: [% IF group.is_bug_group %] + value="[% group.name FILTER html %]" required> [% ELSE %] [% group.name FILTER html %] [% END %] @@ -44,7 +44,7 @@ [% IF group.is_bug_group %] + value="[% group.description FILTER html %]" required> [% ELSE %] [% group.description FILTER html %] [% END %] diff --git a/mozilla/webtools/bugzilla/template/en/default/admin/keywords/create.html.tmpl b/mozilla/webtools/bugzilla/template/en/default/admin/keywords/create.html.tmpl index 3c310cce04b..21ecaf92008 100644 --- a/mozilla/webtools/bugzilla/template/en/default/admin/keywords/create.html.tmpl +++ b/mozilla/webtools/bugzilla/template/en/default/admin/keywords/create.html.tmpl @@ -20,7 +20,7 @@ - + @@ -30,6 +30,7 @@ minrows = 4 cols = 64 wrap = 'virtual' + mandatory = 1 %] diff --git a/mozilla/webtools/bugzilla/template/en/default/admin/keywords/edit.html.tmpl b/mozilla/webtools/bugzilla/template/en/default/admin/keywords/edit.html.tmpl index 1c3d1c3c551..23158d36fc6 100644 --- a/mozilla/webtools/bugzilla/template/en/default/admin/keywords/edit.html.tmpl +++ b/mozilla/webtools/bugzilla/template/en/default/admin/keywords/edit.html.tmpl @@ -20,7 +20,7 @@ + value="[% keyword.name FILTER html %]" required> @@ -31,6 +31,7 @@ cols = 64 wrap = 'virtual' defaultcontent = keyword.description + mandatory = 1 %] diff --git a/mozilla/webtools/bugzilla/template/en/default/admin/milestones/create.html.tmpl b/mozilla/webtools/bugzilla/template/en/default/admin/milestones/create.html.tmpl index d15e43d5569..4f1a2414400 100644 --- a/mozilla/webtools/bugzilla/template/en/default/admin/milestones/create.html.tmpl +++ b/mozilla/webtools/bugzilla/template/en/default/admin/milestones/create.html.tmpl @@ -25,7 +25,7 @@ + autofocus required> diff --git a/mozilla/webtools/bugzilla/template/en/default/admin/milestones/edit.html.tmpl b/mozilla/webtools/bugzilla/template/en/default/admin/milestones/edit.html.tmpl index 86d0ebc1e22..cbc7330fe24 100644 --- a/mozilla/webtools/bugzilla/template/en/default/admin/milestones/edit.html.tmpl +++ b/mozilla/webtools/bugzilla/template/en/default/admin/milestones/edit.html.tmpl @@ -26,7 +26,7 @@ + [%- milestone.name FILTER html %]" required> diff --git a/mozilla/webtools/bugzilla/template/en/default/admin/products/create.html.tmpl b/mozilla/webtools/bugzilla/template/en/default/admin/products/create.html.tmpl index da63a2ff5c1..b34f67b629a 100644 --- a/mozilla/webtools/bugzilla/template/en/default/admin/products/create.html.tmpl +++ b/mozilla/webtools/bugzilla/template/en/default/admin/products/create.html.tmpl @@ -37,7 +37,7 @@ diff --git a/mozilla/webtools/bugzilla/template/en/default/admin/products/edit-common.html.tmpl b/mozilla/webtools/bugzilla/template/en/default/admin/products/edit-common.html.tmpl index 6faa0746919..baf5015ae0b 100644 --- a/mozilla/webtools/bugzilla/template/en/default/admin/products/edit-common.html.tmpl +++ b/mozilla/webtools/bugzilla/template/en/default/admin/products/edit-common.html.tmpl @@ -22,12 +22,12 @@ - diff --git a/mozilla/webtools/bugzilla/template/en/default/admin/sudo.html.tmpl b/mozilla/webtools/bugzilla/template/en/default/admin/sudo.html.tmpl index a5f13a015d6..d4faf4ea769 100644 --- a/mozilla/webtools/bugzilla/template/en/default/admin/sudo.html.tmpl +++ b/mozilla/webtools/bugzilla/template/en/default/admin/sudo.html.tmpl @@ -41,6 +41,7 @@ value => target_login_default accesskey => "u" size => 30 + mandatory => 1 %]

@@ -69,7 +70,7 @@ password: - +
This is done for two reasons. First of all, it is done to reduce the chances of someone doing large amounts of damage using your diff --git a/mozilla/webtools/bugzilla/template/en/default/admin/users/userdata.html.tmpl b/mozilla/webtools/bugzilla/template/en/default/admin/users/userdata.html.tmpl index 8cdc767e4f2..c08cd001808 100644 --- a/mozilla/webtools/bugzilla/template/en/default/admin/users/userdata.html.tmpl +++ b/mozilla/webtools/bugzilla/template/en/default/admin/users/userdata.html.tmpl @@ -23,7 +23,7 @@ [% IF editusers %] + [%- " autofocus" UNLESS editform %] required> [% IF editform %] [% IF !otheruser.in_group('bz_sudo_protect') %]
@@ -72,7 +72,7 @@ + value="" required>
Name:
Description:
Name:
Description:
Version: + value="[% version FILTER html %]" required>
Product: + value="[% product.name FILTER html %]" required>
Description:
+ value="" autocomplete="off" [% 'required' IF !editform %]> [% IF password_complexity == "mixed_letters" %] (Password must contain at least one UPPER and one lowercase letter.) [% ELSIF password_complexity == "letters_numbers" %] diff --git a/mozilla/webtools/bugzilla/template/en/default/admin/versions/create.html.tmpl b/mozilla/webtools/bugzilla/template/en/default/admin/versions/create.html.tmpl index 46bd38c17c2..648adcebd75 100644 --- a/mozilla/webtools/bugzilla/template/en/default/admin/versions/create.html.tmpl +++ b/mozilla/webtools/bugzilla/template/en/default/admin/versions/create.html.tmpl @@ -25,7 +25,7 @@
diff --git a/mozilla/webtools/bugzilla/template/en/default/admin/versions/edit.html.tmpl b/mozilla/webtools/bugzilla/template/en/default/admin/versions/edit.html.tmpl index 4ea202c04a2..1ef0b2f66ec 100644 --- a/mozilla/webtools/bugzilla/template/en/default/admin/versions/edit.html.tmpl +++ b/mozilla/webtools/bugzilla/template/en/default/admin/versions/edit.html.tmpl @@ -26,7 +26,7 @@
+ value="[% version.name FILTER html %]" required>