From 6c7a64415971ce8dca087765ac052eeb481dddb0 Mon Sep 17 00:00:00 2001 From: "ian%hixie.ch" Date: Sat, 10 Nov 2001 20:53:37 +0000 Subject: [PATCH] Changed a comment in UserField.pm to be more accurate: it is actually safe to change the userID on the fly from an undefined value to a defined value because the code only uses it at two points: creation, if it was defined (used by the caller) and destruction (at which point it is passed to the data source to save any changes). git-svn-id: svn://10.0.0.236/trunk@107841 18797224-902f-48f8-a5cc-f745e15eee43 --- mozilla/webtools/PLIF/PLIF/Service/UserField.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mozilla/webtools/PLIF/PLIF/Service/UserField.pm b/mozilla/webtools/PLIF/PLIF/Service/UserField.pm index dfdc521993f..c36c2281c12 100644 --- a/mozilla/webtools/PLIF/PLIF/Service/UserField.pm +++ b/mozilla/webtools/PLIF/PLIF/Service/UserField.pm @@ -58,7 +58,7 @@ sub init { my($app, $user, $fieldID, $fieldCategory, $fieldName, $fieldTypeData, $fieldMode, $fieldData) = @_; # do not hold on to $user! $self->app($app); - $self->userID($user->userID); # change this at your peril + $self->userID($user->userID); # only change this if it started as undef $self->fieldID($fieldID); # change this at your peril $self->category($fieldCategory); # change this at your peril $self->name($fieldName); # change this at your peril