Bommels05/Mozilla
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix typo in nsRuleNode::ClearCachedDataInSubtree so it only clears data associated with |aRule|. This fixes a crash since nsStyleContext::ClearStyleData didn't make the same mistake and clean up dangling pointers to the incorrectly deleted data. b=105619 r=bzbarsky sr=brendan a=shaver

Browse Source 
git-svn-id: svn://10.0.0.236/trunk@115660 18797224-902f-48f8-a5cc-f745e15eee43
This commit is contained in:
dbaron%fas.harvard.edu
2002-03-03 00:02:00 +00:00
parent d16a2c3b7c
commit 6ef2ae37f0
2 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
mozilla/content/base/src/nsRuleNode.cpp
View File

@@ -526,6 +526,7 @@ nsRuleNode::ClearCachedData(nsIStyleRule* aRule)
// of inline style, all nodes along this path must have exactly one child. This
// is not a bushy subtree, and so we know that by clearing this path, we've
// invalidated everything that we need to.
// XXXldb What about !important :hover rules, and such?
nsRuleNode* curr = this;
while (curr) {
curr->mNoneBits &= ~NS_STYLE_INHERIT_MASK;
@@ -560,7 +561,7 @@ nsRuleNode::ClearCachedDataInSubtree(nsIStyleRule* aRule)
mStyleData.Destroy(0, mPresContext);
mNoneBits &= ~NS_STYLE_INHERIT_MASK;
mDependentBits &= ~NS_STYLE_INHERIT_MASK;
aRule = nsnull;
aRule = nsnull; // Cause everything to be blown away in the descendants.
}
if (!mParent) {
@@ -569,7 +570,7 @@ nsRuleNode::ClearCachedDataInSubtree(nsIStyleRule* aRule)
}
else
for (nsRuleList* curr = mChildren; curr; curr = curr->mNext)
curr->mRuleNode->ClearCachedDataInSubtree(curr->mRuleNode->mRule);
curr->mRuleNode->ClearCachedDataInSubtree(aRule);
return NS_OK;
}