diff --git a/mozilla/webtools/bugzilla/Bugzilla/Bug.pm b/mozilla/webtools/bugzilla/Bugzilla/Bug.pm index cfc01ba7b60..d941a766e1c 100644 --- a/mozilla/webtools/bugzilla/Bugzilla/Bug.pm +++ b/mozilla/webtools/bugzilla/Bugzilla/Bug.pm @@ -2853,11 +2853,16 @@ sub GetComments { INNER JOIN profiles ON profiles.userid = longdescs.who WHERE longdescs.bug_id = ?'; + if ($start) { - $query .= ' AND longdescs.bug_when > ? - AND longdescs.bug_when <= ?'; - push(@args, ($start, $end)); + $query .= ' AND longdescs.bug_when > ?'; + push(@args, $start); } + if ($end) { + $query .= ' AND longdescs.bug_when <= ?'; + push(@args, $end); + } + $query .= " ORDER BY longdescs.bug_when $sort_order"; my $sth = $dbh->prepare($query); $sth->execute(@args); diff --git a/mozilla/webtools/bugzilla/Bugzilla/WebService/Bug.pm b/mozilla/webtools/bugzilla/Bugzilla/WebService/Bug.pm index 10ea1f88633..9d58538f2ec 100644 --- a/mozilla/webtools/bugzilla/Bugzilla/WebService/Bug.pm +++ b/mozilla/webtools/bugzilla/Bugzilla/WebService/Bug.pm @@ -78,7 +78,7 @@ sub comments { my $bug = Bugzilla::Bug->check($bug_id); # We want the API to always return comments in the same order. my $comments = Bugzilla::Bug::GetComments( - $bug->id, 'oldest_to_newest'); + $bug->id, 'oldest_to_newest', $params->{new_since}); my @result; foreach my $comment (@$comments) { next if $comment->{isprivate} && !$user->is_insider; @@ -439,6 +439,13 @@ C An array of integer comment_ids. These comments will be returned individually, separate from any other comments in their respective bugs. +=item C + +C If specified, the method will only return comments I +than this time. This only affects comments returned from the C +argument. You will always be returned all comments you request in the +C argument, even if they are older than this date. + =back =item B