From 709e40a664c8d9bb8764fafdec1fbc63fbe6576e Mon Sep 17 00:00:00 2001 From: "ccooper%deadsquid.com" Date: Tue, 28 Aug 2007 18:33:10 +0000 Subject: [PATCH] - handle case where no testcase ID is given git-svn-id: svn://10.0.0.236/trunk@233229 18797224-902f-48f8-a5cc-f745e15eee43 --- mozilla/webtools/litmus/manage_testcases.cgi | 32 ++++++++++++-------- 1 file changed, 19 insertions(+), 13 deletions(-) diff --git a/mozilla/webtools/litmus/manage_testcases.cgi b/mozilla/webtools/litmus/manage_testcases.cgi index f36d2bfc3ca..cacf5b752a0 100755 --- a/mozilla/webtools/litmus/manage_testcases.cgi +++ b/mozilla/webtools/litmus/manage_testcases.cgi @@ -103,21 +103,27 @@ if ($c->param("testcase_id")) { my $defaults; if ($c->param("delete_testcase_button")) { - my $testcase = Litmus::DB::Testcase->retrieve($testcase_id); - if ($testcase) { - Litmus::Auth::requireProductAdmin("manage_testcases.cgi", $testcase->product()); - $rv = $testcase->delete_with_refs(); - if ($rv) { - $status = "success"; - $message = "Testcase ID# $testcase_id deleted successfully."; - } else { + my $testcase; + if ($testcase_id) { + $testcase = Litmus::DB::Testcase->retrieve($testcase_id); + if ($testcase) { + Litmus::Auth::requireProductAdmin("manage_testcases.cgi", $testcase->product()); + $rv = $testcase->delete_with_refs(); + if ($rv) { + $status = "success"; + $message = "Testcase ID# $testcase_id deleted successfully."; + } else { + $status = "failure"; + $message = "Failed to delete Testcase ID# $testcase_id."; + } + } else { $status = "failure"; - $message = "Failed to delete Testcase ID# $testcase_id."; + $message = "Testcase ID# $testcase_id does not exist. (Already deleted?)"; } - } else { - $status = "failure"; - $message = "Testcase ID# $testcase_id does not exist. (Already deleted?)"; - } + } else { + $status = "failure"; + $message = "No testcase ID provided."; + } } elsif ($c->param("clone_testcase_button")) { my $testcase = Litmus::DB::Testcase->retrieve($testcase_id); Litmus::Auth::requireProductAdmin("manage_testcases.cgi", $testcase->product());