Bommels05/Mozilla
Bommels05/Mozilla
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

bug 235832, dynamic_cast crashes. replace with static_cast.

Browse Source 
r=bzbarsky sr=darin


git-svn-id: svn://10.0.0.236/trunk@153404 18797224-902f-48f8-a5cc-f745e15eee43
This commit is contained in:
cbiesinger%web.de 2004-03-01 21:18:19 +00:00
parent 013981479f
commit 70d8ae809b
1 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
mozilla/uriloader/exthandler/mac/nsOSHelperAppService.cpp
View File

@ -221,10 +221,14 @@ nsOSHelperAppService::GetMIMEInfoFromOS(const char * aMIMEType,
if (!hasDefault && miByType && miByExt) {
// IC currently always uses nsMIMEInfoBase-derived classes.
// When it stops doing that, this code will need changing.
// Using dynamic_cast here so we can fail sorta gracefully if this is no
// nsMIMEInfoBase.
nsMIMEInfoBase* byType = dynamic_cast<nsMIMEInfoBase*>(miByType.get());
nsMIMEInfoBase* byExt = dynamic_cast<nsMIMEInfoBase*>(miByExt.get());
// XXX This assumes that IC will give os an nsMIMEInfoBase. I'd use
// dynamic_cast but that crashes.
// XXX these pBy* variables are needed because .get() returns an
// nsDerivedSafe thingy that can't be cast to nsMIMEInfoBase*
nsIMIMEInfo* pByType = miByType.get();
nsIMIMEInfo* pByExt = miByExt.get();
nsMIMEInfoBase* byType = NS_STATIC_CAST(nsMIMEInfoBase*, pByType);
nsMIMEInfoBase* byExt = NS_STATIC_CAST(nsMIMEInfoBase*, pByExt);
if (!byType || !byExt) {
NS_ERROR("IC gave us an nsIMIMEInfo that's no nsMIMEInfoBase! Fix nsOSHelperAppService.");
return nsnull;