From 777c9cb186ecc5ce833ff29213d5a339ca8dd03b Mon Sep 17 00:00:00 2001
From: "sayrer%gmail.com"
 <sayrer%gmail.com@18797224-902f-48f8-a5cc-f745e15eee43>
Date: Fri, 28 Jul 2006 02:09:20 +0000
Subject: [PATCH] Bug 336892. Feed preview leaks 1 docshell and 2 documents.
 Patch By Ben Gooder <bugs@bengoodger.com>. r=darin, a=drivers

git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_8_BRANCH@205023 18797224-902f-48f8-a5cc-f745e15eee43
---
 .../components/feeds/src/FeedConverter.js     | 84 +++++++++++--------
 1 file changed, 48 insertions(+), 36 deletions(-)

diff --git a/mozilla/browser/components/feeds/src/FeedConverter.js b/mozilla/browser/components/feeds/src/FeedConverter.js
index 600a301f26c..ab348544a21 100644
--- a/mozilla/browser/components/feeds/src/FeedConverter.js
+++ b/mozilla/browser/components/feeds/src/FeedConverter.js
@@ -134,7 +134,15 @@ FeedConverter.prototype = {
    * Whether or not the preview page is being forced.
    */
   _forcePreviewPage: false,
-  
+
+  /** 
+  * Release our references to various things once we're done using them.
+  */
+  _releaseHandles: function FC__releaseHandles() {
+    this._listener = null;
+    this._request = null;
+  },
+
   /**
    * See nsIFeedResultListener.idl
    */
@@ -169,46 +177,50 @@ FeedConverter.prototype = {
     //
     // If this is just a feed, not some kind of specialized application, then
     // auto-handlers can be set and we should obey them. 
-    var feedService = 
-        Cc["@mozilla.org/browser/feeds/result-service;1"].
-        getService(Ci.nsIFeedResultService);
-    if (!this._forcePreviewPage) {
-      var skipPreview = safeGetBoolPref(PREF_SKIP_PREVIEW_PAGE, false);
-      if (skipPreview) {
-        var handler = safeGetCharPref(PREF_SELECTED_HANDLER, "bookmarks");
-        if (handler == "web") {
-          var wccr = 
-              Cc["@mozilla.org/embeddor.implemented/web-content-handler-registrar;1"].
-              getService(Ci.nsIWebContentConverterService);
-          var feed = result.doc.QueryInterface(Ci.nsIFeed);
-          if (feed.type == Ci.nsIFeed.TYPE_FEED &&
-              wccr.getAutoHandler(TYPE_MAYBE_FEED)) {
-            wccr.loadPreferredHandler(this._request);
+    try {
+      var feedService = 
+          Cc["@mozilla.org/browser/feeds/result-service;1"].
+          getService(Ci.nsIFeedResultService);
+      if (!this._forcePreviewPage) {
+        var skipPreview = safeGetBoolPref(PREF_SKIP_PREVIEW_PAGE, false);
+        if (skipPreview) {
+          var handler = safeGetCharPref(PREF_SELECTED_HANDLER, "bookmarks");
+          if (handler == "web") {
+            var wccr = 
+                Cc["@mozilla.org/embeddor.implemented/web-content-handler-registrar;1"].
+                getService(Ci.nsIWebContentConverterService);
+            var feed = result.doc.QueryInterface(Ci.nsIFeed);
+            if (feed.type == Ci.nsIFeed.TYPE_FEED &&
+                wccr.getAutoHandler(TYPE_MAYBE_FEED)) {
+              wccr.loadPreferredHandler(this._request);
+              return;
+            }
+          }
+          else {
+            feedService.addToClientReader(this._request, result.uri.spec);
             return;
           }
         }
-        else {
-          feedService.addToClientReader(this._request, result.uri.spec);
-          return;
-        }
       }
-    }
-        
-    // If there was no automatic handler, or this was a podcast, photostream or
-    // some other kind of application, we must always show the preview page...
-  
-    // Store the result in the result service so that the display page can 
-    // access it.
-    feedService.addFeedResult(result);
 
-    // Now load the actual XUL document.
-    var ios = 
-        Cc["@mozilla.org/network/io-service;1"].
-        getService(Ci.nsIIOService);
-    var chromeURI = ios.newURI(FEEDHANDLER_URI, null, null);
-    var chromeChannel = ios.newChannelFromURI(chromeURI, null);
-    chromeChannel.originalURI = result.uri;
-    chromeChannel.asyncOpen(this._listener, null);
+      // If there was no automatic handler, or this was a podcast, photostream or
+      // some other kind of application, we must always show the preview page...
+      // Store the result in the result service so that the display page can 
+      // access it.
+      feedService.addFeedResult(result);
+      
+      // Now load the actual XUL document.
+      var ios = 
+           Cc["@mozilla.org/network/io-service;1"].
+           getService(Ci.nsIIOService);
+      var chromeURI = ios.newURI(FEEDHANDLER_URI, null, null);
+      var chromeChannel = ios.newChannelFromURI(chromeURI, null);
+      chromeChannel.originalURI = result.uri;
+      chromeChannel.asyncOpen(this._listener, null);
+    }
+    finally {
+      this._releaseHandles();
+    }
   },
   
   /**