From 7b339c9d3a1d0b3d4486bc8fab493c6a4ebbe742 Mon Sep 17 00:00:00 2001 From: "davidmc%netscape.com" Date: Mon, 19 Apr 1999 22:19:50 +0000 Subject: [PATCH] add checks for negative mork_pos values during qualification of valid indexes into a morkArray. Also cast integer types to quell some compiler warnings about signed/unsigned. git-svn-id: svn://10.0.0.236/trunk@28121 18797224-902f-48f8-a5cc-f745e15eee43 --- mozilla/db/mork/src/morkArray.cpp | 6 +++--- mozilla/mailnews/db/mork/src/morkArray.cpp | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/mozilla/db/mork/src/morkArray.cpp b/mozilla/db/mork/src/morkArray.cpp index ac198ca82d9..927e526178a 100644 --- a/mozilla/db/mork/src/morkArray.cpp +++ b/mozilla/db/mork/src/morkArray.cpp @@ -193,7 +193,7 @@ morkArray::SafeAt(morkEnv* ev, mork_pos inPos) { if ( mArray_Slots ) { - if ( inPos < mArray_Fill ) + if ( inPos >= 0 && inPos < (mork_pos) mArray_Fill ) return mArray_Slots[ inPos ]; else this->IndexBeyondEndError(ev); @@ -209,7 +209,7 @@ morkArray::SafeAtPut(morkEnv* ev, mork_pos inPos, void* ioSlot) { if ( mArray_Slots ) { - if ( inPos < mArray_Fill ) + if ( inPos >= 0 && inPos < (mork_pos) mArray_Fill ) { mArray_Slots[ inPos ] = ioSlot; ++mArray_Seed; @@ -270,7 +270,7 @@ void morkArray::CutSlot(morkEnv* ev, mork_pos inPos) { mork_fill fill = mArray_Fill; - if ( inPos < fill ) // cutting a slot in the used array portion? + if ( inPos >= 0 && inPos < (mork_pos) fill ) // cutting slot in used array portion? { void** slot = mArray_Slots; // the slot vector void** end = slot + fill; // one past the last used array slot diff --git a/mozilla/mailnews/db/mork/src/morkArray.cpp b/mozilla/mailnews/db/mork/src/morkArray.cpp index ac198ca82d9..927e526178a 100644 --- a/mozilla/mailnews/db/mork/src/morkArray.cpp +++ b/mozilla/mailnews/db/mork/src/morkArray.cpp @@ -193,7 +193,7 @@ morkArray::SafeAt(morkEnv* ev, mork_pos inPos) { if ( mArray_Slots ) { - if ( inPos < mArray_Fill ) + if ( inPos >= 0 && inPos < (mork_pos) mArray_Fill ) return mArray_Slots[ inPos ]; else this->IndexBeyondEndError(ev); @@ -209,7 +209,7 @@ morkArray::SafeAtPut(morkEnv* ev, mork_pos inPos, void* ioSlot) { if ( mArray_Slots ) { - if ( inPos < mArray_Fill ) + if ( inPos >= 0 && inPos < (mork_pos) mArray_Fill ) { mArray_Slots[ inPos ] = ioSlot; ++mArray_Seed; @@ -270,7 +270,7 @@ void morkArray::CutSlot(morkEnv* ev, mork_pos inPos) { mork_fill fill = mArray_Fill; - if ( inPos < fill ) // cutting a slot in the used array portion? + if ( inPos >= 0 && inPos < (mork_pos) fill ) // cutting slot in used array portion? { void** slot = mArray_Slots; // the slot vector void** end = slot + fill; // one past the last used array slot