Bommels05/Mozilla
Bommels05/Mozilla
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Adding some XXX comments regarding a known bug (when the user is changing their address, fields try to update the database before the new address has been authenticated)

Browse Source 
git-svn-id: svn://10.0.0.236/trunk@95992 18797224-902f-48f8-a5cc-f745e15eee43
This commit is contained in:
ian%hixie.ch 2001-05-29 09:11:33 +00:00
parent 10a6e949df
commit 7d520650d0
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
mozilla/webtools/PLIF/PLIF/Service/User.pm
View File

@ -163,6 +163,10 @@ sub prepareAddressChange {
$self->newFieldID($field->fieldID);
$self->newFieldValue($newAddress);
$self->newFieldPassword($password);
# XXX I don't like the way this is done. A better way would be
# to clone $self, then tweak the one field being changed. This
# still doesn't deal with telling the fields and the user
# object not to write themselves to the database though. XXX
my $session = $self->objectCreate($self->app, $self->userID, $self->mode, $self->adminMessage,
$self->newFieldID, $self->newFieldValue, $self->newFieldPassword,
# XXX need to pass the other fields in
@ -182,6 +186,7 @@ sub prepareAddressAddition {
$self->newFieldID($field->fieldID);
$self->newFieldValue($newAddress);
$self->newFieldPassword($password);
# XXX see comment above
my $session = $self->objectCreate($self->app, $self->userID, $self->mode, $self->adminMessage,
$self->newFieldID, $self->newFieldValue, $self->newFieldPassword,
# XXX need to pass the other fields in
@ -301,7 +306,7 @@ sub DESTROY {
if ($self->{'_DIRTY'}->{'groups'}) {
$self->writeGroups();
}
}
} # else, this is a fake user, don't save the data. Note: Fields still save data! XXX
}
sub writeProperties {