Bommels05/Mozilla
Bommels05/Mozilla
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Disabled caching for encoders since they hold states, bug 48284, r=cata,ftang.

Browse Source 
git-svn-id: svn://10.0.0.236/trunk@76126 18797224-902f-48f8-a5cc-f745e15eee43
This commit is contained in:
nhotta%netscape.com 2000-08-11 20:13:31 +00:00
parent 19cc303013
commit 80721dda88
1 changed files with 3 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
mozilla/intl/uconv/src/nsCharsetConverterManager.cpp
View File

@ -46,7 +46,7 @@ static NS_DEFINE_CID(kStringBundleServiceCID, NS_STRINGBUNDLESERVICE_CID);
static NS_DEFINE_CID(kLocaleServiceCID, NS_LOCALESERVICE_CID);
static NS_DEFINE_CID(kSupportsArrayCID, NS_SUPPORTSARRAY_CID);
// Pattern of cached, commonly used, single byte encoder and decoder
// Pattern of cached, commonly used, single byte decoder
#define NS_1BYTE_CODER_PATTERN "ISO-8859"
#define NS_1BYTE_CODER_PATTERN_LEN 8
//----------------------------------------------------------------------------
@ -485,15 +485,8 @@ NS_IMETHODIMP nsCharsetConverterManager::GetUnicodeEncoder(
aDest->ToCString(progid + baselen, 256 - baselen);
nsCOMPtr<nsIUnicodeEncoder> encoder;
if (!strncmp(progid+baselen, NS_1BYTE_CODER_PATTERN, NS_1BYTE_CODER_PATTERN_LEN))
{
// Single byte encoders/decoders dont hold state. Optimize by using a service.
encoder = do_GetService(progid, &res);
}
else
{
encoder = do_CreateInstance(progid, &res);
}
// Always create an instance since encoders hold state.
encoder = do_CreateInstance(progid, &res);
if (NS_FAILED(res))
res = NS_ERROR_UCONV_NOCONV;