Bommels05/Mozilla
Bommels05/Mozilla
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

bug 430758 - GetAccessible() could be fooled by additional table ancestor

Browse Source 
patch by evan.yan@sun.com (Evan Yan)
r=surkov
a1.9=beltzner


git-svn-id: svn://10.0.0.236/trunk@251161 18797224-902f-48f8-a5cc-f745e15eee43
This commit is contained in:
marco.zehe%googlemail.com 2008-05-04 05:39:21 +00:00
parent f4094189c6
commit 80b5750b44
2 changed files with 33 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
mozilla/accessible/src/base/nsAccessibilityService.cpp
View File

@ -1526,7 +1526,7 @@ NS_IMETHODIMP nsAccessibilityService::GetAccessible(nsIDOMNode *aNode,
}
break;
}
else if (tableFrame->GetType() == nsAccessibilityAtoms::tableCellFrame) {
else if (tableContent->Tag() == nsAccessibilityAtoms::table) {
// Stop before we are fooled by any additional table ancestors
// This table cell frameis part of a separate ancestor table.
tryTagNameOrFrame = PR_FALSE;

32
mozilla/accessible/tests/mochitest/test_nsIAccessibleTable_4.html
View File

@ -100,6 +100,26 @@ function doTest()
is(accTable4.cellRefAt(1,1).firstChild.name, "cell3", "wrong cell");
}
// Test table with display:inline and an outside table. We shouldn't be fooled
// by the outside table and shouldn't create table accessible and table cell
// accessible in this case
var table5 = document.getElementById("table5");
accNotCreated = false;
try {
var accTable1 = accService.getAccessibleFor(table1);
} catch (e) {
accNotCreated = true;
}
ok(accNotCreated, "wrongly created table accessible");
var t5Cell = document.getElementById("t5_cell");
accNotCreated = false;
try {
var accCell = accService.getAccessibleFor(t5Cell);
} catch (e) {
accNotCreated = true;
}
ok(accNotCreated, "wrongly created table cell accessible");
SimpleTest.finish();
}
SimpleTest.waitForExplicitFinish();
@ -150,6 +170,18 @@ addLoadEvent(doTest);
<td>cell3</td>
</tr>
</table>
<table>
<tr>
<td style="display:block">
<table style="display:inline" id="table5">
<tr><td id="t5_cell">cell0</td></tr>
</table>
</td>
<td>cell1</td>
</tr>
</table>
</center>
</body>
</html>