From 8268850a6076aa2972120a90aeb25d851bfd457d Mon Sep 17 00:00:00 2001 From: "bzbarsky%mit.edu" Date: Wed, 16 Feb 2005 15:26:04 +0000 Subject: [PATCH] If AsyncOpen fails, don't leave the imgRequest in the cache, since it will never deliver any notifications to its listeners. Bug 281467, r=pavalov, sr=darin, a=asa git-svn-id: svn://10.0.0.236/trunk@169249 18797224-902f-48f8-a5cc-f745e15eee43 --- mozilla/modules/libpr0n/src/imgLoader.cpp | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/mozilla/modules/libpr0n/src/imgLoader.cpp b/mozilla/modules/libpr0n/src/imgLoader.cpp index 162bc833935..801bc887833 100644 --- a/mozilla/modules/libpr0n/src/imgLoader.cpp +++ b/mozilla/modules/libpr0n/src/imgLoader.cpp @@ -495,6 +495,7 @@ NS_IMETHODIMP imgLoader::LoadImage(nsIURI *aURI, // create the proxy listener ProxyListener *pl = new ProxyListener(NS_STATIC_CAST(nsIStreamListener *, request)); if (!pl) { + request->Cancel(NS_ERROR_OUT_OF_MEMORY); NS_RELEASE(request); return NS_ERROR_OUT_OF_MEMORY; } @@ -510,6 +511,10 @@ NS_IMETHODIMP imgLoader::LoadImage(nsIURI *aURI, NS_RELEASE(pl); if (NS_FAILED(openRes)) { + PR_LOG(gImgLog, PR_LOG_DEBUG, + ("[this=%p] imgLoader::LoadImage -- AsyncOpen() failed: 0x%x\n", + this, openRes)); + request->Cancel(openRes); NS_RELEASE(request); return openRes; }