Bommels05/Mozilla
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 286235: Implicit joins should be replaced by explicit joins - installment A

Browse Source 
Patch By Tomas Kopal <Tomas.Kopal@altap.cz> r=joel, a=myk


git-svn-id: svn://10.0.0.236/trunk@171610 18797224-902f-48f8-a5cc-f745e15eee43
This commit is contained in:
mkanat%kerio.com
2005-04-04 21:52:06 +00:00
parent e7bb9f5e7a
commit 833b2e61f6
18 changed files with 211 additions and 175 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
mozilla/webtools/bugzilla/userprefs.cgi
View File

@@ -177,8 +177,9 @@ sub DoEmail {
###########################################################################
if (Param("supportwatchers")) {
my $watched_ref = $dbh->selectcol_arrayref(
"SELECT profiles.login_name FROM watch, profiles"
. " WHERE watcher = ? AND watch.watched = profiles.userid",
"SELECT profiles.login_name FROM watch INNER JOIN profiles" .
" ON watch.watched = profiles.userid" .
" WHERE watcher = ?",
undef, $userid);
$vars->{'watchedusers'} = join(',', @$watched_ref);
@@ -307,9 +308,10 @@ sub SaveEmail {
sub DoPermissions {
my (@has_bits, @set_bits);
SendSQL("SELECT DISTINCT name, description FROM groups, user_group_map " .
"WHERE user_group_map.group_id = groups.id " .
"AND user_id = $::userid " .
SendSQL("SELECT DISTINCT name, description FROM groups " .
"INNER JOIN user_group_map " .
"ON user_group_map.group_id = groups.id " .
"WHERE user_id = $::userid " .
"AND isbless = 0 " .
"ORDER BY name");
while (MoreSQLData()) {