From 856851dc6a21c8b2c7a38768d162e483ad1420a9 Mon Sep 17 00:00:00 2001 From: "jst%mozilla.jstenback.com" Date: Fri, 2 Dec 2005 00:50:19 +0000 Subject: [PATCH] Fixing bug 318270. Fix refcount problem in ns4xPluginInstance::GetDOMWindow() that lead to crashes due to window objects being deleted too quickly. r=mrbkap@gmail.com, r+sr=bzbarsky@mit.edu git-svn-id: svn://10.0.0.236/trunk@185557 18797224-902f-48f8-a5cc-f745e15eee43 --- mozilla/modules/plugin/base/src/ns4xPluginInstance.cpp | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/mozilla/modules/plugin/base/src/ns4xPluginInstance.cpp b/mozilla/modules/plugin/base/src/ns4xPluginInstance.cpp index ea26a579ace..d68c54ebf3a 100644 --- a/mozilla/modules/plugin/base/src/ns4xPluginInstance.cpp +++ b/mozilla/modules/plugin/base/src/ns4xPluginInstance.cpp @@ -957,7 +957,10 @@ ns4xPluginInstance::GetDOMWindow() return nsnull; } - return doc->GetWindow(); + nsPIDOMWindow *window = doc->GetWindow(); + NS_IF_ADDREF(window); + + return window; } ////////////////////////////////////////////////////////////////////////