From 871a42ae7ced296ca5f4bb8a5b888ee0e9ba104b Mon Sep 17 00:00:00 2001
From: "gavin%gavinsharp.com"
 <gavin%gavinsharp.com@18797224-902f-48f8-a5cc-f745e15eee43>
Date: Mon, 7 Nov 2005 04:49:19 +0000
Subject: [PATCH] Followup to bug 315004, r=mconnor.

git-svn-id: svn://10.0.0.236/trunk@184227 18797224-902f-48f8-a5cc-f745e15eee43
---
 mozilla/toolkit/mozapps/extensions/content/about.js   | 10 +++++++++-
 mozilla/toolkit/mozapps/extensions/content/about.xul  |  1 +
 .../toolkit/mozapps/extensions/content/extensions.js  | 11 +++++++++--
 .../toolkit/mozapps/extensions/content/extensions.xul |  1 +
 4 files changed, 20 insertions(+), 3 deletions(-)

diff --git a/mozilla/toolkit/mozapps/extensions/content/about.js b/mozilla/toolkit/mozapps/extensions/content/about.js
index 5406e95d118..d24a692ea10 100644
--- a/mozilla/toolkit/mozapps/extensions/content/about.js
+++ b/mozilla/toolkit/mozapps/extensions/content/about.js
@@ -74,7 +74,15 @@ function init()
   if (homepage) {
     homepage = homepage.QueryInterface(Components.interfaces.nsIRDFLiteral).Value;
     // only allow http(s) homepages
-    if (!/^https?:/.test(homepage))
+    var scheme = "";
+    var uri = null;
+    try {
+      uri = makeURI(homepage);
+      scheme = uri.scheme;
+    } catch (ex) {}
+    if (uri && (scheme == "http" || scheme == "https"))
+      homepage = uri.spec;
+    else
       homepage = null;
   }
     
diff --git a/mozilla/toolkit/mozapps/extensions/content/about.xul b/mozilla/toolkit/mozapps/extensions/content/about.xul
index 0850747ad33..5558bae2674 100644
--- a/mozilla/toolkit/mozapps/extensions/content/about.xul
+++ b/mozilla/toolkit/mozapps/extensions/content/about.xul
@@ -48,6 +48,7 @@
         buttons="accept" onload="init();" onaccept="close();">
 
   <script type="application/x-javascript" src="chrome://mozapps/content/extensions/about.js"/>
+  <script type="application/x-javascript" src="chrome://global/content/contentAreaUtils.js"/>
   
   <stringbundleset id="aboutSet">
     <stringbundle id="extensionsStrings" src="chrome://mozapps/locale/extensions/extensions.properties"/>
diff --git a/mozilla/toolkit/mozapps/extensions/content/extensions.js b/mozilla/toolkit/mozapps/extensions/content/extensions.js
index 9a2efeab4b6..19fe4f1d955 100644
--- a/mozilla/toolkit/mozapps/extensions/content/extensions.js
+++ b/mozilla/toolkit/mozapps/extensions/content/extensions.js
@@ -1002,8 +1002,15 @@ var gExtensionsViewController = {
     {
       if (!aSelectedItem) return;
       var homepageURL = aSelectedItem.getAttribute("homepageURL");
-      if (/^https?:/.test(homepageURL))
-        openURL(homepageURL);
+      // only allow http(s) homepages
+      var scheme = "";
+      var uri = null;
+      try {
+        uri = makeURI(homepageURL);
+        scheme = uri.scheme;
+      } catch (ex) {}
+      if (uri && (scheme == "http" || scheme == "https"))
+        openURL(uri.spec);
     },
     
     cmd_about: function (aSelectedItem)
diff --git a/mozilla/toolkit/mozapps/extensions/content/extensions.xul b/mozilla/toolkit/mozapps/extensions/content/extensions.xul
index 5e357e8bc1f..ee604a7b464 100644
--- a/mozilla/toolkit/mozapps/extensions/content/extensions.xul
+++ b/mozilla/toolkit/mozapps/extensions/content/extensions.xul
@@ -59,6 +59,7 @@
         onclose="return closeWindow(false);">
 
   <script type="application/x-javascript" src="chrome://global/content/globalOverlay.js"/>
+  <script type="application/x-javascript" src="chrome://global/content/contentAreaUtils.js"/>
   <script type="application/x-javascript" src="chrome://mozapps/content/extensions/extensions.js"/>
   <script type="application/x-javascript" src="chrome://global/content/nsDragAndDrop.js"/>
   <script type="application/x-javascript" src="chrome://global/content/nsTransferable.js"/>