From 8a36bac6ecb4635e020adcdcf4cddcc1f43c44f4 Mon Sep 17 00:00:00 2001 From: "bryner%uiuc.edu" Date: Thu, 23 Mar 2000 06:40:36 +0000 Subject: [PATCH] Don't allow a port other than 79 to be used for finger. r=valeski. git-svn-id: svn://10.0.0.236/trunk@63833 18797224-902f-48f8-a5cc-f745e15eee43 --- mozilla/extensions/finger/nsFingerChannel.cpp | 7 ++++--- mozilla/netwerk/protocol/finger/src/nsFingerChannel.cpp | 7 ++++--- 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/mozilla/extensions/finger/nsFingerChannel.cpp b/mozilla/extensions/finger/nsFingerChannel.cpp index 747436479ea..62923c9913a 100644 --- a/mozilla/extensions/finger/nsFingerChannel.cpp +++ b/mozilla/extensions/finger/nsFingerChannel.cpp @@ -69,9 +69,10 @@ nsFingerChannel::Init(const char* verb, mOriginalURI = originalURI ? originalURI : uri; mUrl = uri; - rv = mUrl->GetPort(&mPort); - if (NS_FAILED(rv) || mPort < 1) - mPort = FINGER_PORT; +// For security reasons, we do not allow the user to specify a +// non-default port for finger: URL's. + + mPort = FINGER_PORT; rv = mUrl->GetPath(getter_Copies(autoBuffer)); // autoBuffer = user@host if (NS_FAILED(rv)) return rv; diff --git a/mozilla/netwerk/protocol/finger/src/nsFingerChannel.cpp b/mozilla/netwerk/protocol/finger/src/nsFingerChannel.cpp index 747436479ea..62923c9913a 100644 --- a/mozilla/netwerk/protocol/finger/src/nsFingerChannel.cpp +++ b/mozilla/netwerk/protocol/finger/src/nsFingerChannel.cpp @@ -69,9 +69,10 @@ nsFingerChannel::Init(const char* verb, mOriginalURI = originalURI ? originalURI : uri; mUrl = uri; - rv = mUrl->GetPort(&mPort); - if (NS_FAILED(rv) || mPort < 1) - mPort = FINGER_PORT; +// For security reasons, we do not allow the user to specify a +// non-default port for finger: URL's. + + mPort = FINGER_PORT; rv = mUrl->GetPath(getter_Copies(autoBuffer)); // autoBuffer = user@host if (NS_FAILED(rv)) return rv;