Bommels05/Mozilla
Bommels05/Mozilla
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix bugzilla bug #2568

Browse Source 
nsHttpUrlImpl::GetContainer was always returning with NS_OK even if the container is nil.  After discussing it with rpotts I've changed it to return NS_ERROR_UNEXPECTED if mContainer is nil which fixes the Mac crash (calling QueryInterface on a nil container is probably bad everywhere though).


git-svn-id: svn://10.0.0.236/trunk@21815 18797224-902f-48f8-a5cc-f745e15eee43
This commit is contained in:
sdagley%netscape.com 1999-02-25 01:28:24 +00:00
parent cd2d4a3130
commit 8b53976170
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
mozilla/network/module/nsHttpUrl.cpp
View File

@ -818,7 +818,10 @@ nsresult nsHttpUrlImpl::GetContainer(nsISupports* *result) const
*result = mContainer;
NS_IF_ADDREF(mContainer);
NS_UNLOCK_INSTANCE();
return NS_OK;
if (mContainer)
return NS_OK;
else
return NS_ERROR_UNEXPECTED; // Indicate an error if no container
}
nsresult nsHttpUrlImpl::SetContainer(nsISupports* container)