326346 - javascript error when selecting text on a page. r=annie.sullivan@gmail.com

git-svn-id: svn://10.0.0.236/trunk@189385 18797224-902f-48f8-a5cc-f745e15eee43
This commit is contained in:
beng%bengoodger.com 2006-02-08 01:53:22 +00:00
parent 1e648c080b
commit 900d71e4f3

View File

@ -545,7 +545,7 @@ var PlacesController = {
*/
onCommandUpdate: function PC_onCommandUpdate() {
if (!this._activeView) {
// Initial command update, no view yet.
// Initial update, no view is set yet
return;
}
@ -576,8 +576,12 @@ var PlacesController = {
this.nodeIsFolder(this._activeView.selectedNode);
this._setEnabled("placesCmd_open:tabs",
singleFolderSelected || !hasSingleSelection);
var viewIsFolder = this.nodeIsFolder(this._activeView.getResult().root);
// Some views, like menupopups, destroy their result as they hide, but they
// are still the "last-active" view. Don't barf.
var result = this._activeView.getResult();
var viewIsFolder = result ? this.nodeIsFolder(result.root) : false;
// Persistent Sort
this._setEnabled("placesCmd_sortby:name", viewIsFolder);
// New Folder
@ -1410,6 +1414,8 @@ var PlacesControllerDragHelper = {
* The number of visible items to be inserted. This can be zero
* even when items are dropped because this is how many items will
* be _visible_ in the resulting tree.
* XXXben this parameter appears to be unused! check call sites.
* check d&d feedback.
*/
onDrop: function PCDH_onDrop(sourceView, targetView, insertionPoint,
visibleInsertCount) {