From 907eec02fcd27e72b2effe0cd20251efec2bcfe4 Mon Sep 17 00:00:00 2001 From: "rpotts%netscape.com" Date: Sun, 10 Oct 1999 06:58:42 +0000 Subject: [PATCH] Removed 2 *extra* calls to NS_RELEASE in failure cases... git-svn-id: svn://10.0.0.236/trunk@50325 18797224-902f-48f8-a5cc-f745e15eee43 --- mozilla/layout/base/src/nsPluginViewer.cpp | 5 +---- mozilla/modules/plugin/base/src/nsPluginViewer.cpp | 5 +---- mozilla/modules/plugin/nglsrc/nsPluginViewer.cpp | 5 +---- 3 files changed, 3 insertions(+), 12 deletions(-) diff --git a/mozilla/layout/base/src/nsPluginViewer.cpp b/mozilla/layout/base/src/nsPluginViewer.cpp index 8a18bc0462d..fb5f7141f96 100644 --- a/mozilla/layout/base/src/nsPluginViewer.cpp +++ b/mozilla/layout/base/src/nsPluginViewer.cpp @@ -629,14 +629,11 @@ PluginListener::OnStartRequest(nsIURI* aURL, const char *contentType) rv = channel->GetContentType(&contentType); if (NS_FAILED(rv)) { - NS_RELEASE(channel); return rv; } rv = mViewer->StartLoad(channel, mNextStream); - if (NS_FAILED(rv)) - { - NS_RELEASE(channel); + if (NS_FAILED(rv)) { return rv; } #else diff --git a/mozilla/modules/plugin/base/src/nsPluginViewer.cpp b/mozilla/modules/plugin/base/src/nsPluginViewer.cpp index 8a18bc0462d..fb5f7141f96 100644 --- a/mozilla/modules/plugin/base/src/nsPluginViewer.cpp +++ b/mozilla/modules/plugin/base/src/nsPluginViewer.cpp @@ -629,14 +629,11 @@ PluginListener::OnStartRequest(nsIURI* aURL, const char *contentType) rv = channel->GetContentType(&contentType); if (NS_FAILED(rv)) { - NS_RELEASE(channel); return rv; } rv = mViewer->StartLoad(channel, mNextStream); - if (NS_FAILED(rv)) - { - NS_RELEASE(channel); + if (NS_FAILED(rv)) { return rv; } #else diff --git a/mozilla/modules/plugin/nglsrc/nsPluginViewer.cpp b/mozilla/modules/plugin/nglsrc/nsPluginViewer.cpp index 8a18bc0462d..fb5f7141f96 100644 --- a/mozilla/modules/plugin/nglsrc/nsPluginViewer.cpp +++ b/mozilla/modules/plugin/nglsrc/nsPluginViewer.cpp @@ -629,14 +629,11 @@ PluginListener::OnStartRequest(nsIURI* aURL, const char *contentType) rv = channel->GetContentType(&contentType); if (NS_FAILED(rv)) { - NS_RELEASE(channel); return rv; } rv = mViewer->StartLoad(channel, mNextStream); - if (NS_FAILED(rv)) - { - NS_RELEASE(channel); + if (NS_FAILED(rv)) { return rv; } #else