Bommels05/Mozilla
Bommels05/Mozilla
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 380398: appversion manifest flag has a broken length check. r=bsmedberg

Browse Source 
git-svn-id: svn://10.0.0.236/trunk@226615 18797224-902f-48f8-a5cc-f745e15eee43
This commit is contained in:
dtownsend%oxymoronical.com 2007-05-18 13:42:06 +00:00
parent c07b945efb
commit 90c568d6e6
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
mozilla/chrome/src/nsChromeRegistry.cpp
View File

@ -1975,7 +1975,7 @@ CheckVersionFlag(const nsSubstring& aFlag, const nsSubstring& aData,
const nsSubstring& aValue, nsIVersionComparator* aChecker,
TriState& aResult)
{
if (! (aData.Length() > aFlag.Length() + 2))
if (aData.Length() < aFlag.Length() + 2)
return PR_FALSE;
if (!StringBeginsWith(aData, aFlag))
@ -2016,6 +2016,9 @@ CheckVersionFlag(const nsSubstring& aFlag, const nsSubstring& aData,
return PR_FALSE;
}
if (testdata.Length() == 0)
return PR_FALSE;
if (aResult != eOK) {
if (!aChecker) {
aResult = eBad;