Bommels05/Mozilla
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 58221 don't use strlen to check if a string is of length 0

Browse Source 
patch by aaronl@vitelus.com r=timeless sr=bz


git-svn-id: svn://10.0.0.236/trunk@133999 18797224-902f-48f8-a5cc-f745e15eee43
This commit is contained in:
timeless%mozdev.org
2002-11-17 05:16:49 +00:00
parent 6063118db9
commit 99731b5e88
55 changed files with 142 additions and 139 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
mozilla/modules/plugin/samples/default/os2/plugin.cpp
View File

@@ -105,28 +105,28 @@ CPlugin::CPlugin(HMODULE hInst,
assert(m_hInst != NULL);
assert(m_pNPInstance != NULL);
if((pluginType != NULL) && (strlen((PSZ)pluginType) != 0))
if(pluginType && *pluginType)
{
m_pNPMIMEType = (NPMIMEType)new char[strlen((PSZ)pluginType) + 1];
if(m_pNPMIMEType != NULL)
strcpy((PSZ)m_pNPMIMEType, pluginType);
}
if((szPageURL != NULL) && (strlen(szPageURL) != 0))
if(szPageURL && *szPageURL)
{
m_szPageURL = new char[strlen(szPageURL) + 1];
if(m_szPageURL != NULL)
strcpy(m_szPageURL, szPageURL);
}
if((szFileURL != NULL) && (strlen(szFileURL) != 0))
if(szFileURL && *szFileURL)
{
m_szFileURL = new char[strlen(szFileURL) + 1];
if(m_szFileURL != NULL)
strcpy(m_szFileURL, szFileURL);
}
if((szFileExtension != NULL) && (strlen(szFileExtension) != 0))
if(szFileExtension && *szFileExtension)
{
m_szFileExtension = new char[strlen(szFileExtension) + 1];
if(m_szFileExtension != NULL)
@@ -137,7 +137,7 @@ CPlugin::CPlugin(HMODULE hInst,
char szString[1024] = {'\0'};
WinLoadString((HAB)0, m_hInst, IDS_CLICK_TO_GET, sizeof(szString), szString);
if(strlen(szString) != 0)
if(*szString)
{
m_szCommandMessage = new char[strlen(szString) + 1];
if(m_szCommandMessage != NULL)
@@ -446,7 +446,7 @@ void CPlugin::showGetPluginDialog()
char szString[1024] = {'\0'};
WinLoadString((HAB)0, m_hInst, IDS_CLICK_WHEN_DONE, sizeof(szString), szString);
if(strlen(szString) != 0)
if(*szString)
{
m_szCommandMessage = new char[strlen(szString) + 1];
if(m_szCommandMessage != NULL)

2
mozilla/modules/plugin/samples/default/os2/utils.cpp
View File

@@ -100,7 +100,7 @@ static int getWindowStringLength(HWND hWnd, PSZ lpsz)
void SetDlgItemTextWrapped(HWND hWnd, int iID, PSZ szText)
{
HWND hWndStatic = WinWindowFromID(hWnd, iID);
if((szText == NULL) || (strlen(szText) == 0))
if(!szText || !*szText)
{
WinSetDlgItemText(hWnd, iID, "");
return;