From 9e2b131e640bbcc64828fae4e849cf2107020390 Mon Sep 17 00:00:00 2001 From: "tingley%sundell.net" Date: Thu, 5 Feb 2004 01:08:07 +0000 Subject: [PATCH] bug 232854: RemoveBroadcastListenerFor wasn't removing listeners properly. r=varga sr=bzbarsky git-svn-id: svn://10.0.0.236/trunk@152322 18797224-902f-48f8-a5cc-f745e15eee43 --- mozilla/content/xul/document/src/nsXULDocument.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/mozilla/content/xul/document/src/nsXULDocument.cpp b/mozilla/content/xul/document/src/nsXULDocument.cpp index 4edea4b7639..a01afd0c200 100644 --- a/mozilla/content/xul/document/src/nsXULDocument.cpp +++ b/mozilla/content/xul/document/src/nsXULDocument.cpp @@ -966,7 +966,8 @@ nsXULDocument::RemoveBroadcastListenerFor(nsIDOMElement* aBroadcaster, NS_STATIC_CAST(BroadcastListener*, entry->mListeners[i]); if ((bl->mListener == aListener) && (bl->mAttribute == attr)) { - entry->mListeners.RemoveElement(aListener); + entry->mListeners.RemoveElementAt(i); + delete bl; if (entry->mListeners.Count() == 0) PL_DHashTableOperate(mBroadcasterMap, aBroadcaster,