Bommels05/Mozilla
Bommels05/Mozilla
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Changed InsertChild() to use <= (instead of <) for zindex check, and changed

Browse Source 
iteration to use sibling pointers


git-svn-id: svn://10.0.0.236/trunk@15800 18797224-902f-48f8-a5cc-f745e15eee43
This commit is contained in:
troy%netscape.com 1998-12-04 21:28:52 +00:00
parent 16560ce56e
commit 9fad935195
1 changed files with 15 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
mozilla/view/src/nsViewManager.cpp
View File

@ -734,21 +734,21 @@ NS_IMETHODIMP nsViewManager :: InsertChild(nsIView *parent, nsIView *child, nsIV
if ((nsnull != parent) && (nsnull != child))
{
PRInt32 numkids;
parent->GetChildCount(numkids);
nsIView *kid = nsnull, *prev = nsnull;
nsIView *kid;
nsIView *prev = nsnull;
//verify that the sibling exists...
for (PRInt32 cnt = 0; cnt < numkids; cnt++)
parent->GetChild(0, kid);
while (nsnull != kid)
{
// XXX This is extremely inefficient...
parent->GetChild(cnt, kid);
if (kid == sibling)
break;
//get the next sibling view
prev = kid;
kid->GetNextSibling(kid);
}
if (nsnull != kid)
@ -780,25 +780,24 @@ NS_IMETHODIMP nsViewManager :: InsertChild(nsIView *parent, nsIView *child, PRIn
if ((nsnull != parent) && (nsnull != child))
{
PRInt32 numkids;
parent->GetChildCount(numkids);
nsIView *kid = nsnull, *prev = nsnull;
nsIView *kid;
nsIView *prev = nsnull;
//find the right insertion point...
for (PRInt32 cnt = 0; cnt < numkids; cnt++)
parent->GetChild(0, kid);
while (nsnull != kid)
{
PRInt32 idx;
// XXX This is extremely inefficient...
parent->GetChild(cnt, kid);
kid->GetZIndex(idx);
if (zindex < idx)
if (zindex <= idx)
break;
//get the next sibling view
prev = kid;
kid->GetNextSibling(kid);
}
//in case this hasn't been set yet... maybe we should not do this? MMP