From a426ec7a3613cb1b95ed77c186d2ff417d85fda4 Mon Sep 17 00:00:00 2001 From: "hyatt%netscape.com" Date: Tue, 11 Jan 2000 19:49:04 +0000 Subject: [PATCH] Removing my lame comment. git-svn-id: svn://10.0.0.236/trunk@57412 18797224-902f-48f8-a5cc-f745e15eee43 --- .../layout/html/table/src/nsTableOuterFrame.cpp | 14 +++++++------- mozilla/layout/tables/nsTableOuterFrame.cpp | 14 +++++++------- 2 files changed, 14 insertions(+), 14 deletions(-) diff --git a/mozilla/layout/html/table/src/nsTableOuterFrame.cpp b/mozilla/layout/html/table/src/nsTableOuterFrame.cpp index f1bf5b711d5..f8af985149d 100644 --- a/mozilla/layout/html/table/src/nsTableOuterFrame.cpp +++ b/mozilla/layout/html/table/src/nsTableOuterFrame.cpp @@ -591,14 +591,14 @@ nsresult nsTableOuterFrame::IR_InnerTableReflow(nsIPresContext* aPresCont nsHTMLReflowState innerReflowState(aPresContext, aReflowState.reflowState, mInnerTableFrame, nsSize(tableMaxWidth, aReflowState.reflowState.availableHeight)); - // Tables are completely screwed up. They do not really obey mComputedWidth and mComputedHeight, - // and when the innerReflowState is constructed, they attempt to set it themselves by looking - // for their styled width and height. This is totally bogus, since there's no reason to - // believe that those #s are always accurate now that the notion of flex has been - // introduced. + // When the above reflow state is constructed, mComputedWidth and mComputedHeight get set + // to the table's styled width and height. Flex from XUL boxes can make the styled #s + // inaccurate, which means that mComputedWidth and mComputedHeight from the parent + // reflow state should be used instead. - // The following function will at least make trees behave properly inside boxes. Maybe one - // day we'll be able to make tables behave too. + // The following function will patch the reflow state so that trees behave properly inside boxes. + // This might work for tables as well, but until regression tests can be run to make sure, + // I'm holding off on patching tables. FixBadReflowState(aReflowState.reflowState, innerReflowState); // If we're supposed to update our maximum width, then ask the child to diff --git a/mozilla/layout/tables/nsTableOuterFrame.cpp b/mozilla/layout/tables/nsTableOuterFrame.cpp index f1bf5b711d5..f8af985149d 100644 --- a/mozilla/layout/tables/nsTableOuterFrame.cpp +++ b/mozilla/layout/tables/nsTableOuterFrame.cpp @@ -591,14 +591,14 @@ nsresult nsTableOuterFrame::IR_InnerTableReflow(nsIPresContext* aPresCont nsHTMLReflowState innerReflowState(aPresContext, aReflowState.reflowState, mInnerTableFrame, nsSize(tableMaxWidth, aReflowState.reflowState.availableHeight)); - // Tables are completely screwed up. They do not really obey mComputedWidth and mComputedHeight, - // and when the innerReflowState is constructed, they attempt to set it themselves by looking - // for their styled width and height. This is totally bogus, since there's no reason to - // believe that those #s are always accurate now that the notion of flex has been - // introduced. + // When the above reflow state is constructed, mComputedWidth and mComputedHeight get set + // to the table's styled width and height. Flex from XUL boxes can make the styled #s + // inaccurate, which means that mComputedWidth and mComputedHeight from the parent + // reflow state should be used instead. - // The following function will at least make trees behave properly inside boxes. Maybe one - // day we'll be able to make tables behave too. + // The following function will patch the reflow state so that trees behave properly inside boxes. + // This might work for tables as well, but until regression tests can be run to make sure, + // I'm holding off on patching tables. FixBadReflowState(aReflowState.reflowState, innerReflowState); // If we're supposed to update our maximum width, then ask the child to