Bommels05/Mozilla
Bommels05/Mozilla
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 825758: Most Bugzilla::BugUrl::* modules incorrectly validate the domain name

Browse Source 
r/a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@264749 18797224-902f-48f8-a5cc-f745e15eee43
This commit is contained in:
mkanat%bugzilla.org 2013-02-16 22:30:58 +00:00
parent 2f2234daf8
commit a66f442174
9 changed files with 10 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
mozilla/webtools/bugzilla/.bzrrev
View File

@ -1 +1 @@
8577 8578

2
mozilla/webtools/bugzilla/Bugzilla/BugUrl/Debian.pm
View File

@ -22,7 +22,7 @@ sub should_handle {
# Debian BTS URLs can look like various things: # Debian BTS URLs can look like various things:
# http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1234 # http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1234
# http://bugs.debian.org/1234 # http://bugs.debian.org/1234
return ($uri->authority =~ /^bugs.debian.org$/i return (lc($uri->authority) eq 'bugs.debian.org'
and (($uri->path =~ /bugreport\.cgi$/ and (($uri->path =~ /bugreport\.cgi$/
and $uri->query_param('bug') =~ m|^\d+$|) and $uri->query_param('bug') =~ m|^\d+$|)
or $uri->path =~ m|^/\d+$|)) ? 1 : 0; or $uri->path =~ m|^/\d+$|)) ? 1 : 0;

2
mozilla/webtools/bugzilla/Bugzilla/BugUrl/GitHub.pm
View File

@ -21,7 +21,7 @@ sub should_handle {
# GitHub issue URLs have only one form: # GitHub issue URLs have only one form:
# https://github.com/USER_OR_TEAM_OR_ORGANIZATION_NAME/REPOSITORY_NAME/issues/111 # https://github.com/USER_OR_TEAM_OR_ORGANIZATION_NAME/REPOSITORY_NAME/issues/111
return ($uri->authority =~ /^github.com$/i return (lc($uri->authority) eq 'github.com'
and $uri->path =~ m|^/[^/]+/[^/]+/issues/\d+$|) ? 1 : 0; and $uri->path =~ m|^/[^/]+/[^/]+/issues/\d+$|) ? 1 : 0;
} }

2
mozilla/webtools/bugzilla/Bugzilla/BugUrl/Google.pm
View File

@ -21,7 +21,7 @@ sub should_handle {
# Google Code URLs only have one form: # Google Code URLs only have one form:
# http(s)://code.google.com/p/PROJECT_NAME/issues/detail?id=1234 # http(s)://code.google.com/p/PROJECT_NAME/issues/detail?id=1234
return ($uri->authority =~ /^code.google.com$/i return (lc($uri->authority) eq 'code.google.com'
and $uri->path =~ m|^/p/[^/]+/issues/detail$| and $uri->path =~ m|^/p/[^/]+/issues/detail$|
and $uri->query_param('id') =~ /^\d+$/) ? 1 : 0; and $uri->query_param('id') =~ /^\d+$/) ? 1 : 0;
} }

2
mozilla/webtools/bugzilla/Bugzilla/BugUrl/Launchpad.pm
View File

@ -23,7 +23,7 @@ sub should_handle {
# https://bugs.launchpad.net/ubuntu/+bug/1234 # https://bugs.launchpad.net/ubuntu/+bug/1234
# https://launchpad.net/bugs/1234 # https://launchpad.net/bugs/1234
# All variations end with either "/bugs/1234" or "/+bug/1234" # All variations end with either "/bugs/1234" or "/+bug/1234"
return ($uri->authority =~ /launchpad.net$/ return ($uri->authority =~ /launchpad\.net$/
and $uri->path =~ m|bugs?/\d+$|) ? 1 : 0; and $uri->path =~ m|bugs?/\d+$|) ? 1 : 0;
} }

2
mozilla/webtools/bugzilla/Bugzilla/BugUrl/SourceForge.pm
View File

@ -21,7 +21,7 @@ sub should_handle {
# SourceForge tracker URLs have only one form: # SourceForge tracker URLs have only one form:
# http://sourceforge.net/tracker/?func=detail&aid=111&group_id=111&atid=111 # http://sourceforge.net/tracker/?func=detail&aid=111&group_id=111&atid=111
return ($uri->authority =~ /^sourceforge.net$/i return (lc($uri->authority) eq 'sourceforge.net'
and $uri->path =~ m|/tracker/| and $uri->path =~ m|/tracker/|
and $uri->query_param('func') eq 'detail' and $uri->query_param('func') eq 'detail'
and $uri->query_param('aid') and $uri->query_param('aid')

2
mozilla/webtools/bugzilla/extensions/MoreBugUrl/lib/GetSatisfaction.pm
View File

@ -20,7 +20,7 @@ sub should_handle {
# GetSatisfaction URLs only have one form: # GetSatisfaction URLs only have one form:
# http(s)://getsatisfaction.com/PROJECT_NAME/topics/TOPIC_NAME # http(s)://getsatisfaction.com/PROJECT_NAME/topics/TOPIC_NAME
return ($uri->authority =~ /^getsatisfaction.com$/i return (lc($uri->authority) eq 'getsatisfaction.com'
and $uri->path =~ m|^/[^/]+/topics/[^/]+$|) ? 1 : 0; and $uri->path =~ m|^/[^/]+/topics/[^/]+$|) ? 1 : 0;
} }

4
mozilla/webtools/bugzilla/extensions/MoreBugUrl/lib/PHP.pm
View File

@ -20,8 +20,8 @@ sub should_handle {
# PHP Bug URLs have only one form: # PHP Bug URLs have only one form:
# https://bugs.php.net/bug.php?id=1234 # https://bugs.php.net/bug.php?id=1234
return ($uri->authority =~ /^bugs.php.net$/i return (lc($uri->authority) eq 'bugs.php.net'
and $uri->path =~ m|/bug.php$| and $uri->path =~ m|/bug\.php$|
and $uri->query_param('id') =~ /^\d+$/) ? 1 : 0; and $uri->query_param('id') =~ /^\d+$/) ? 1 : 0;
} }

2
mozilla/webtools/bugzilla/extensions/MoreBugUrl/lib/RT.pm
View File

@ -21,7 +21,7 @@ sub should_handle {
# RT URLs can look like various things: # RT URLs can look like various things:
# http://example.com/rt/Ticket/Display.html?id=1234 # http://example.com/rt/Ticket/Display.html?id=1234
# https://example.com/Public/Bug/Display.html?id=1234 # https://example.com/Public/Bug/Display.html?id=1234
return ($uri->path =~ m|/Display.html$| return ($uri->path =~ m|/Display\.html$|
and $uri->query_param('id') =~ /^\d+$/) ? 1 : 0; and $uri->query_param('id') =~ /^\d+$/) ? 1 : 0;
} }