Bommels05/Mozilla
Bommels05/Mozilla
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 377564: Indexes are not renamed when renaming tables

Browse Source 
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@224734 18797224-902f-48f8-a5cc-f745e15eee43
This commit is contained in:
mkanat%bugzilla.org 2007-04-19 13:01:04 +00:00
parent c01f85b439
commit ad7fca36b7
3 changed files with 41 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
mozilla/webtools/bugzilla/Bugzilla/DB.pm
View File

@ -841,6 +841,17 @@ sub bz_table_columns {
return $self->_bz_real_schema->get_table_columns($table);
}
sub bz_table_indexes {
my ($self, $table) = @_;
my $indexes = $self->_bz_real_schema->get_table_indexes_abstract($table);
my %return_indexes;
# We do this so that they're always hashes.
foreach my $name (keys %$indexes) {
$return_indexes{$name} = $self->bz_index_info($table, $name);
}
return \%return_indexes;
}
#####################################################################
# Protected "Real Database" Schema Information Methods
#####################################################################

7
mozilla/webtools/bugzilla/Bugzilla/DB/Schema.pm
View File

@ -1588,6 +1588,13 @@ sub get_table_columns {
} #eosub--get_table_columns
sub get_table_indexes_abstract {
my ($self, $table) = @_;
my $table_def = $self->get_table_abstract($table);
my %indexes = @{$table_def->{INDEXES} || []};
return \%indexes;
}
sub get_create_database_sql {
my ($self, $name) = @_;
return ("CREATE DATABASE $name");

24
mozilla/webtools/bugzilla/Bugzilla/Install/DB.pm
View File

@ -504,6 +504,7 @@ sub update_table_definitions {
{TYPE => 'MEDIUMSERIAL', NOTNULL => 1, PRIMARYKEY => 1});
_fix_uppercase_custom_field_names();
_fix_uppercase_index_names();
################################################################
# New --TABLE-- changes should go *** A B O V E *** this point #
@ -2750,7 +2751,28 @@ sub _fix_uppercase_custom_field_names {
undef, lc($name), $name);
}
}
}
sub _fix_uppercase_index_names {
# We forgot to fix indexes in the above code.
my $dbh = Bugzilla->dbh;
my $fields = $dbh->selectcol_arrayref(
'SELECT name FROM fielddefs WHERE type = ? AND custom = 1',
undef, FIELD_TYPE_SINGLE_SELECT);
foreach my $field (@$fields) {
my $indexes = $dbh->bz_table_indexes($field);
foreach my $name (keys %$indexes) {
next if $name eq lc($name);
my $index = $indexes->{$name};
# Lowercase the name and everything in the definition.
my $new_name = lc($name);
my @new_fields = map {lc($_)} @{$index->{FIELDS}};
my $new_def = {FIELDS => \@new_fields, TYPE => $index->{TYPE}};
$new_def = \@new_fields if !$index->{TYPE};
$dbh->bz_drop_index($field, $name);
$dbh->bz_add_index($field, $new_name, $new_def);
}
}
}
1;