Bommels05/Mozilla
Bommels05/Mozilla
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix for blocker bug #199159

Browse Source 
chrome not repainting, off by one errors in painting.
a rounding problem in ConvertNativeRegionToAppRegion()
thanks to roc for the fix.  rs=sspitzer, a=loanpham


git-svn-id: svn://10.0.0.236/trunk@140354 18797224-902f-48f8-a5cc-f745e15eee43
This commit is contained in:
sspitzer%netscape.com 2003-03-26 19:02:12 +00:00
parent 08b4edbe77
commit af7e2ecd61
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
mozilla/view/src/nsViewManager.cpp
View File

@ -637,12 +637,15 @@ static void ConvertNativeRegionToAppRegion(nsIRegion* aIn, nsRegion* aOut,
float p2t;
context->GetDevUnitsToAppUnits(p2t);
// roc says:
// we mustn't introduce any off by one errors here, so stick to integer arithmetic
// this assumes that p2t is an integer, but if it isn't, all kinds of other stuff breaks anyway
int pt2i = (int)floor(p2t+0.5);
PRUint32 i;
for (i = 0; i < rects->mNumRects; i++) {
const nsRegionRect& inR = rects->mRects[i];
nsRect outR(inR.x, inR.y, inR.width, inR.height);
outR.ScaleRoundOut(p2t);
nsRect outR(inR.x*pt2i, inR.y*pt2i, inR.width*pt2i, inR.height*pt2i);
aOut->Or(*aOut, outR);
}