diff --git a/mozilla/webtools/tinderbox/showbuilds.pl b/mozilla/webtools/tinderbox/showbuilds.pl
index 8174dfcdf7c..97e1f950c0e 100644
--- a/mozilla/webtools/tinderbox/showbuilds.pl
+++ b/mozilla/webtools/tinderbox/showbuilds.pl
@@ -600,7 +600,7 @@ sub who_menu {
require "$tree/treedata.pl";
my $qr = '';
- my $ret = "";
+ my $ret = "";
if ($use_viewvc) {
$qr = "${viewvc_url}?view=query&who_match=exact&who=" .
&url_encode($who) . "&querysort=date&date=explicit" .
@@ -695,6 +695,7 @@ sub print_javascript {
#popup {
position: absolute;
margin: -5em 0 0 -5em;
+ opacity: 0.9;
}
.who#popup{
border: 0px;
diff --git a/mozilla/webtools/tinderbox/tbglobals.pl b/mozilla/webtools/tinderbox/tbglobals.pl
index 605b270a88d..f11755e76c6 100755
--- a/mozilla/webtools/tinderbox/tbglobals.pl
+++ b/mozilla/webtools/tinderbox/tbglobals.pl
@@ -268,10 +268,14 @@ sub format_time_difference {
return $formatted_diff;
}
+# This should really adhere to:
+# http://www.blooberry.com/indexdot/html/topics/urlencoding.htm
sub url_encode {
my ($s) = @_;
+ # First change all percent signs since later encodings use them as escapes.
$s =~ s/\%/\%25/g;
+
$s =~ s/\=/\%3d/g;
$s =~ s/\?/\%3f/g;
$s =~ s/ /\%20/g;