From b28b86c55a22f7d0ffca8d7edd45d8281e97ec9d Mon Sep 17 00:00:00 2001 From: "morse%netscape.com" Date: Mon, 10 Aug 1998 20:36:41 +0000 Subject: [PATCH] fixed bug involving freeing of memory that was never allocated, reviewed by Pinkerton git-svn-id: svn://10.0.0.236/trunk@7674 18797224-902f-48f8-a5cc-f745e15eee43 --- mozilla/network/main/singsign.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/mozilla/network/main/singsign.c b/mozilla/network/main/singsign.c index 1e287d314cb..da2716e8bfd 100644 --- a/mozilla/network/main/singsign.c +++ b/mozilla/network/main/singsign.c @@ -1163,9 +1163,11 @@ SI_LoadSignonData(char * filename) { if ((unmungedValue=SECNAV_UnMungeString(buffer+1)) == NULL) { /* this is the free source and there is no obscuring of passwords */ unmungedValue = buffer+1; + StrAllocCopy(value_array[submit.value_cnt++], buffer+1); + } else { + StrAllocCopy(value_array[submit.value_cnt++], unmungedValue); + XP_FREE(unmungedValue); } - StrAllocCopy(value_array[submit.value_cnt++], unmungedValue); - XP_FREE(unmungedValue); } else { StrAllocCopy(value_array[submit.value_cnt++], buffer+1); }