From b46fc05f6c7a9ddd9a799a8e06072f4a0034dc14 Mon Sep 17 00:00:00 2001 From: "mkanat%bugzilla.org" Date: Fri, 4 Mar 2011 00:31:38 +0000 Subject: [PATCH] Remove _join_flag_tables from Search.pm, which was dead code. git-svn-id: svn://10.0.0.236/trunk@262002 18797224-902f-48f8-a5cc-f745e15eee43 --- mozilla/webtools/bugzilla/.bzrrev | 2 +- mozilla/webtools/bugzilla/Bugzilla/Search.pm | 25 -------------------- 2 files changed, 1 insertion(+), 26 deletions(-) diff --git a/mozilla/webtools/bugzilla/.bzrrev b/mozilla/webtools/bugzilla/.bzrrev index e5ebfedd426..19ab125387b 100644 --- a/mozilla/webtools/bugzilla/.bzrrev +++ b/mozilla/webtools/bugzilla/.bzrrev @@ -1 +1 @@ -7740 \ No newline at end of file +7741 \ No newline at end of file diff --git a/mozilla/webtools/bugzilla/Bugzilla/Search.pm b/mozilla/webtools/bugzilla/Bugzilla/Search.pm index 24abc437908..5aef38c055b 100644 --- a/mozilla/webtools/bugzilla/Bugzilla/Search.pm +++ b/mozilla/webtools/bugzilla/Bugzilla/Search.pm @@ -2328,31 +2328,6 @@ sub _percentage_complete { $self->_add_extra_column('actual_time'); } -sub _join_flag_tables { - my ($self, $args) = @_; - my ($joins, $chart_id) = @$args{qw(joins chart_id)}; - - my $attach_table = "attachments_$chart_id"; - my $flags_table = "flags_$chart_id"; - my $extra = $self->_user->is_insider - ? [] : ["$attach_table.isprivate = 0"]; - my $attachments_join = { - table => 'attachments', - as => $attach_table, - extra => $extra, - }; - # We join both the bugs and the attachments table in separately, - # and then the join code will later combine the terms. - my $flags_join = { - table => 'flags', - as => $flags_table, - extra => ["($flags_table.attach_id = $attach_table.attach_id " - . " OR $flags_table.attach_id IS NULL)"], - }; - - push(@$joins, $attachments_join, $flags_join); -} - sub _days_elapsed { my ($self, $args) = @_; my $dbh = Bugzilla->dbh;