From b801661659abdce5202dfd9eac412493ce1d3fc0 Mon Sep 17 00:00:00 2001 From: "darin%netscape.com" Date: Wed, 30 Jan 2002 02:40:27 +0000 Subject: [PATCH] fixes bug 121765 "NS_MakeAbsoluteWithCharset should not URL escape before calling nsIURI::Resolve" r=nhotta, sr=brendan git-svn-id: svn://10.0.0.236/trunk@113180 18797224-902f-48f8-a5cc-f745e15eee43 --- mozilla/content/shared/src/nsHTMLUtils.cpp | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/mozilla/content/shared/src/nsHTMLUtils.cpp b/mozilla/content/shared/src/nsHTMLUtils.cpp index 4061634633a..3f29cb000e9 100644 --- a/mozilla/content/shared/src/nsHTMLUtils.cpp +++ b/mozilla/content/shared/src/nsHTMLUtils.cpp @@ -227,20 +227,6 @@ NS_MakeAbsoluteURIWithCharset(char* *aResult, } } - // Now we need to URL-escape the string. - // XXX andreas.otte has warned that using the nsIIOService::Escape - // method in this way may be too conservative (e.g., it won't - // escape a "#" character that appears in a hostname -- does that - // matter?) But, since there's nothing better, we'll do it... - static const PRInt32 kEscapeConservatively = esc_Forced - 1; - - // XXX Unfortunately, we can't escape "in place". Maybe the new string - // APIs will make that better some day. - nsCAutoString escaped; - nsresult rv = nsStdEscape(spec.get(), kEscapeConservatively, escaped); - if (NS_FAILED(rv)) - return rv; - spec = escaped; } }