From bba77e110b49f0c5d86bbf2e67ff2ea10a09d202 Mon Sep 17 00:00:00 2001 From: "jband%netscape.com" Date: Tue, 5 Sep 2000 20:20:34 +0000 Subject: [PATCH] commenting out dead code that was giving us a useless warning git-svn-id: svn://10.0.0.236/trunk@78156 18797224-902f-48f8-a5cc-f745e15eee43 --- mozilla/content/xul/content/src/nsXULAttributes.cpp | 11 +++++++---- mozilla/rdf/content/src/nsXULAttributes.cpp | 11 +++++++---- 2 files changed, 14 insertions(+), 8 deletions(-) diff --git a/mozilla/content/xul/content/src/nsXULAttributes.cpp b/mozilla/content/xul/content/src/nsXULAttributes.cpp index 0b8fab1c137..b1147733e07 100644 --- a/mozilla/content/xul/content/src/nsXULAttributes.cpp +++ b/mozilla/content/xul/content/src/nsXULAttributes.cpp @@ -693,16 +693,19 @@ nsXULAttributes::GetNamedItem(const nsAReadableString& aName, nsresult rv; *aReturn = nsnull; - PRInt32 nameSpaceID; + // XXX nameSpaceID only used in dead code (that was giving us a warning). + // XXX I'd remove it completely, but maybe it is a useful reminder??? + // PRInt32 nameSpaceID; nsIAtom* name; nsCOMPtr inpNodeInfo; if (NS_FAILED(rv = mContent->NormalizeAttributeString(aName, *getter_AddRefs(inpNodeInfo)))) return rv; - if (kNameSpaceID_Unknown == nameSpaceID) { - nameSpaceID = kNameSpaceID_None; // ignore unknown prefix XXX is this correct? - } + // if (kNameSpaceID_Unknown == nameSpaceID) { + // nameSpaceID = kNameSpaceID_None; // ignore unknown prefix XXX is this correct? + // } + // XXX doing this instead of calling mContent->GetAttribute() will // make it a lot harder to lazily instantiate properties from the // graph. The problem is, how else do we get the named item? diff --git a/mozilla/rdf/content/src/nsXULAttributes.cpp b/mozilla/rdf/content/src/nsXULAttributes.cpp index 0b8fab1c137..b1147733e07 100644 --- a/mozilla/rdf/content/src/nsXULAttributes.cpp +++ b/mozilla/rdf/content/src/nsXULAttributes.cpp @@ -693,16 +693,19 @@ nsXULAttributes::GetNamedItem(const nsAReadableString& aName, nsresult rv; *aReturn = nsnull; - PRInt32 nameSpaceID; + // XXX nameSpaceID only used in dead code (that was giving us a warning). + // XXX I'd remove it completely, but maybe it is a useful reminder??? + // PRInt32 nameSpaceID; nsIAtom* name; nsCOMPtr inpNodeInfo; if (NS_FAILED(rv = mContent->NormalizeAttributeString(aName, *getter_AddRefs(inpNodeInfo)))) return rv; - if (kNameSpaceID_Unknown == nameSpaceID) { - nameSpaceID = kNameSpaceID_None; // ignore unknown prefix XXX is this correct? - } + // if (kNameSpaceID_Unknown == nameSpaceID) { + // nameSpaceID = kNameSpaceID_None; // ignore unknown prefix XXX is this correct? + // } + // XXX doing this instead of calling mContent->GetAttribute() will // make it a lot harder to lazily instantiate properties from the // graph. The problem is, how else do we get the named item?