From bcf5e66f3bff65a9218e6ccbeecadf3d9ca0dff6 Mon Sep 17 00:00:00 2001 From: "dbaron%fas.harvard.edu" Date: Thu, 27 Jul 2000 23:27:00 +0000 Subject: [PATCH] Fix leak of GlobalWindowImpl. r=a=waterson git-svn-id: svn://10.0.0.236/trunk@74962 18797224-902f-48f8-a5cc-f745e15eee43 --- mozilla/xpfe/appshell/src/nsCommonDialogs.cpp | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/mozilla/xpfe/appshell/src/nsCommonDialogs.cpp b/mozilla/xpfe/appshell/src/nsCommonDialogs.cpp index 2b02777de0d..289b2c28269 100644 --- a/mozilla/xpfe/appshell/src/nsCommonDialogs.cpp +++ b/mozilla/xpfe/appshell/src/nsCommonDialogs.cpp @@ -449,14 +449,8 @@ nsresult nsCommonDialogs::Select(nsIDOMWindow *inParent, const PRUnichar *inDial (nsISupports*)ioParamBlock ); if ( argv ) { - nsIDOMWindow *newWindow; - rv = inParent->OpenDialog( jsContext, argv, 4, &newWindow ); - if ( NS_SUCCEEDED( rv ) ) - { - // newWindow->Release(); - } else - { - } + nsCOMPtr newWindow; + rv = inParent->OpenDialog( jsContext, argv, 4, getter_AddRefs(newWindow) ); JS_PopArguments( jsContext, stackPtr ); } else