Bommels05/Mozilla
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 346121: Creating an attachment upon new bug doesn't create attachment link in comment #0 - Patch by Frédéric Buclin <LpSolit@gmail.com> r=bkor a=justdave

Browse Source 
git-svn-id: svn://10.0.0.236/trunk@217545 18797224-902f-48f8-a5cc-f745e15eee43
This commit is contained in:
lpsolit%gmail.com
2006-12-29 22:18:55 +00:00
parent 3d8dad8296
commit c1e595e7c1
2 changed files with 52 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
mozilla/webtools/bugzilla/post_bug.cgi
View File

@@ -187,10 +187,26 @@ if (defined $cgi->param('version')) {
# Add an attachment if requested.
if (defined($cgi->upload('data')) || $cgi->param('attachurl')) {
$cgi->param('isprivate', $cgi->param('commentprivacy'));
Bugzilla::Attachment->insert_attachment_for_bug(!THROW_ERROR,
$bug, $user, $timestamp,
\$vars)
|| ($vars->{'message'} = 'attachment_creation_failed');
my $attach_id = Bugzilla::Attachment->insert_attachment_for_bug(!THROW_ERROR,
$bug, $user, $timestamp, \$vars);
if ($attach_id) {
# Update the comment to include the new attachment ID.
# This string is hardcoded here because Template::quoteUrls()
# expects to find this exact string.
my $new_comment = "Created an attachment (id=$attach_id)\n" .
$cgi->param('description') . "\n";
# We can use $bug->longdescs here because we are sure that the bug
# description is of type CMT_NORMAL. No need to include it if it's
# empty, though.
if ($bug->longdescs->[0]->{'body'} !~ /^\s+$/) {
$new_comment .= "\n" . $bug->longdescs->[0]->{'body'};
}
$bug->update_comment($bug->longdescs->[0]->{'id'}, $new_comment);
}
else {
$vars->{'message'} = 'attachment_creation_failed';
}
# Determine if Patch Viewer is installed, for Diff link
eval {