Bommels05/Mozilla
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix miscellaneous form element leaks. r=pollmann@netscape.com

Browse Source 
git-svn-id: svn://10.0.0.236/trunk@63686 18797224-902f-48f8-a5cc-f745e15eee43
This commit is contained in:
dbaron%fas.harvard.edu
2000-03-22 02:21:33 +00:00
parent eed58ed70c
commit d6149be79b
4 changed files with 18 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
mozilla/layout/html/content/src/nsHTMLOptionElement.cpp
View File

@@ -170,7 +170,7 @@ nsHTMLOptionElement::QueryInterface(REFNSIID aIID, void** aInstancePtr)
if (aIID.Equals(kIJSNativeInitializerIID)) {
nsIJSNativeInitializer* tmp = this;
*aInstancePtr = (void*) tmp;
AddRef();
NS_ADDREF_THIS();
return NS_OK;
}
return NS_NOINTERFACE;
@@ -372,7 +372,8 @@ nsHTMLOptionElement::GetIndex(PRInt32* aIndex)
if (thisNode == thisOption) {
res = NS_OK;
*aIndex = i;
break;
NS_IF_RELEASE(thisOption);
break; // skips the release below, thus release above needed
}
NS_IF_RELEASE(thisOption);
}
@@ -636,10 +637,10 @@ nsHTMLOptionElement::Initialize(JSContext* aContext,
JSString* jsstr = JS_ValueToString(aContext, argv[0]);
if (nsnull != jsstr) {
// Create a new text node and append it to the option
nsIContent* textNode;
nsCOMPtr<nsIContent> textNode;
nsITextContent* content;
result = NS_NewTextNode(&textNode);
result = NS_NewTextNode(getter_AddRefs(textNode));
if (NS_FAILED(result)) {
return result;
}
@@ -657,6 +658,7 @@ nsHTMLOptionElement::Initialize(JSContext* aContext,
return result;
}
// this addrefs textNode:
result = mInner.AppendChildTo(textNode, PR_FALSE);
if (NS_FAILED(result)) {
return result;