Reworked frame factory methods; fixed bug 4519

git-svn-id: svn://10.0.0.236/trunk@31154 18797224-902f-48f8-a5cc-f745e15eee43
1999-05-11 22:03:29 +00:00
parent 126ac23d41
commit de60169b67
142 changed files with 1298 additions and 809 deletions
--- a/mozilla/layout/forms/nsImageControlFrame.cpp
+++ b/mozilla/layout/forms/nsImageControlFrame.cpp
@@ -143,12 +143,17 @@ nsImageControlFrame::nsImageControlFrame()
 }

 nsresult
-NS_NewImageControlFrame(nsIFrame*& aResult)
+NS_NewImageControlFrame(nsIFrame** aNewFrame)
 {
-  aResult = new nsImageControlFrame;
-  if (nsnull == aResult) {
+  NS_PRECONDITION(aNewFrame, "null OUT ptr");
+  if (nsnull == aNewFrame) {
+    return NS_ERROR_NULL_POINTER;
+  }
+  nsImageControlFrame* it = new nsImageControlFrame;
+  if (!it) {
    return NS_ERROR_OUT_OF_MEMORY;
  }
+  *aNewFrame = it;
  return NS_OK;
 }