Bommels05/Mozilla
Bommels05/Mozilla
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[SECURITY] Bug 209376: If you know the email address of someone who has voted on a secure bug, you can access the summary of that bug even if you do not have sufficient permissions to view the bug itself.

Browse Source 
Patch by Gervase Markham <gerv@mozilla.org>
r= justdave, bbaetz  a= justdave


git-svn-id: svn://10.0.0.236/trunk@148735 18797224-902f-48f8-a5cc-f745e15eee43
This commit is contained in:
justdave%syndicomm.com 2003-11-03 03:20:49 +00:00
parent 5f464cc811
commit e052ecbc87
1 changed files with 3 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
mozilla/webtools/bugzilla/votes.cgi
View File

@ -128,12 +128,8 @@ sub show_user {
my $bug_id = $::FORM{'bug_id'} || "";
my $name = $::FORM{'user'} || Bugzilla->user->login;
my $who = DBname_to_id($name);
# After DBNameToIdAndCheck is templatised and prints a Content-Type,
# the above should revert to a call to that function, and this
# special error handling should go away.
$who || ThrowUserError("invalid_username", {name => $name});
my $who = DBNameToIdAndCheck($name);
my $userid = Bugzilla->user ? Bugzilla->user->id : 0;
my $canedit = 1 if (Bugzilla->user &&
$name eq Bugzilla->user->login);
@ -193,7 +189,7 @@ sub show_user {
# and they can see there are votes 'missing', but not on what bug
# they are. This seems a reasonable compromise; the alternative is
# to lie in the totals.
next if !CanSeeBug($id, $who);
next if !CanSeeBug($id, $userid);
push (@bugs, { id => $id,
summary => $summary,