From e27bbbf53f17b445a06d62d657adf5969da720f4 Mon Sep 17 00:00:00 2001 From: "bugzilla%arlen.demon.co.uk" Date: Thu, 7 Sep 2006 22:09:52 +0000 Subject: [PATCH] Bug 132257 Inserting a link to a [network][image] file into a message inserts the physical file! p=me/ducarroz r=daniel/neil sr=bienvenu git-svn-id: svn://10.0.0.236/trunk@209382 18797224-902f-48f8-a5cc-f745e15eee43 --- .../editor/libeditor/html/nsHTMLEditor.cpp | 19 +- .../ui/dialogs/content/EdImageOverlay.xul | 3 +- .../editor/ui/dialogs/content/EdLinkProps.xul | 3 +- mozilla/mail/components/compose/jar.mn | 3 + .../mailComposeEditorOverlay.dtd | 5 + mozilla/mail/locales/jar.mn | 1 + .../base/resources/content/contents.rdf | 10 ++ .../content/mailComposeEditorOverlay.xul | 167 ++++++++++++++++++ .../locale/en-US/mailComposeEditorOverlay.dtd | 5 + mozilla/mailnews/compose/src/nsMsgSend.cpp | 44 ++++- mozilla/mailnews/jar.mn | 2 + mozilla/mailnews/mailnews.js | 4 + 12 files changed, 246 insertions(+), 20 deletions(-) create mode 100755 mozilla/mail/locales/en-US/chrome/messenger/messengercompose/mailComposeEditorOverlay.dtd create mode 100755 mozilla/mailnews/compose/resources/content/mailComposeEditorOverlay.xul create mode 100755 mozilla/mailnews/compose/resources/locale/en-US/mailComposeEditorOverlay.dtd diff --git a/mozilla/editor/libeditor/html/nsHTMLEditor.cpp b/mozilla/editor/libeditor/html/nsHTMLEditor.cpp index e58de752c3e..a580e3ed65d 100644 --- a/mozilla/editor/libeditor/html/nsHTMLEditor.cpp +++ b/mozilla/editor/libeditor/html/nsHTMLEditor.cpp @@ -3847,22 +3847,11 @@ nsHTMLEditor::GetEmbeddedObjects(nsISupportsArray** aNodeList) node->GetNodeName(tagName); ToLowerCase(tagName); - // See if it's an image or an embed - if (tagName.EqualsLiteral("img") || tagName.EqualsLiteral("embed")) + // See if it's an image or an embed and also include all links. + // Let mail decide which link to send or not + if (tagName.EqualsLiteral("img") || tagName.EqualsLiteral("embed") || + tagName.EqualsLiteral("a")) (*aNodeList)->AppendElement(node); - else if (tagName.EqualsLiteral("a")) - { - // Only include links if they're links to file: URLs - nsCOMPtr anchor (do_QueryInterface(content)); - if (anchor) - { - nsAutoString href; - if (NS_SUCCEEDED(anchor->GetHref(href))) - if (StringBeginsWith(href, NS_LITERAL_STRING("file:"), - nsCaseInsensitiveStringComparator())) - (*aNodeList)->AppendElement(node); - } - } else if (tagName.EqualsLiteral("body")) { nsCOMPtr element = do_QueryInterface(node); diff --git a/mozilla/editor/ui/dialogs/content/EdImageOverlay.xul b/mozilla/editor/ui/dialogs/content/EdImageOverlay.xul index b4fd4c7818d..7459b1e0aac 100644 --- a/mozilla/editor/ui/dialogs/content/EdImageOverlay.xul +++ b/mozilla/editor/ui/dialogs/content/EdImageOverlay.xul @@ -59,11 +59,12 @@ tooltiptext="&locationEditField.tooltip;" /> - + +