From e747e9d893f8a2be6c99e495c2a3082da18dcbd9 Mon Sep 17 00:00:00 2001
From: "mrbkap%gmail.com"
 <mrbkap%gmail.com@18797224-902f-48f8-a5cc-f745e15eee43>
Date: Sat, 29 Apr 2006 00:39:03 +0000
Subject: [PATCH] Only call GetCharCode for KeyPress events to avoid triggering
 a warning in nsDOMKeyEvent.cpp. bug 309316, r+sr=dbaron

git-svn-id: svn://10.0.0.236/trunk@195703 18797224-902f-48f8-a5cc-f745e15eee43
---
 mozilla/layout/forms/nsTextControlFrame.cpp | 18 +++++++++++++-----
 1 file changed, 13 insertions(+), 5 deletions(-)

diff --git a/mozilla/layout/forms/nsTextControlFrame.cpp b/mozilla/layout/forms/nsTextControlFrame.cpp
index 61ef475aa08..e54c79b186b 100644
--- a/mozilla/layout/forms/nsTextControlFrame.cpp
+++ b/mozilla/layout/forms/nsTextControlFrame.cpp
@@ -370,7 +370,8 @@ DoCommandCallback(const char *aCommand, void *aData)
 
 static PRBool
 DOMEventToNativeKeyEvent(nsIDOMEvent      *aDOMEvent,
-                         nsNativeKeyEvent *aNativeEvent)
+                         nsNativeKeyEvent *aNativeEvent,
+                         PRBool            aGetCharCode)
 {
   nsCOMPtr<nsIDOMNSUIEvent> uievent = do_QueryInterface(aDOMEvent);
   PRBool defaultPrevented;
@@ -386,7 +387,11 @@ DOMEventToNativeKeyEvent(nsIDOMEvent      *aDOMEvent,
 
   nsCOMPtr<nsIDOMKeyEvent> keyEvent = do_QueryInterface(aDOMEvent);
 
-  keyEvent->GetCharCode(&aNativeEvent->charCode);
+  if (aGetCharCode) {
+      keyEvent->GetCharCode(&aNativeEvent->charCode);
+  } else {
+      aNativeEvent->charCode = 0;
+  }
   keyEvent->GetKeyCode(&aNativeEvent->keyCode);
   keyEvent->GetAltKey(&aNativeEvent->altKey);
   keyEvent->GetCtrlKey(&aNativeEvent->ctrlKey);
@@ -401,7 +406,8 @@ nsTextInputListener::KeyDown(nsIDOMEvent *aKeyEvent)
 {
   nsNativeKeyEvent nativeEvent;
   nsINativeKeyBindings *bindings = GetKeyBindings();
-  if (bindings && DOMEventToNativeKeyEvent(aKeyEvent, &nativeEvent)) {
+  if (bindings &&
+      DOMEventToNativeKeyEvent(aKeyEvent, &nativeEvent, PR_FALSE)) {
     if (bindings->KeyDown(nativeEvent, DoCommandCallback, mFrame)) {
       aKeyEvent->PreventDefault();
     }
@@ -415,7 +421,8 @@ nsTextInputListener::KeyPress(nsIDOMEvent *aKeyEvent)
 {
   nsNativeKeyEvent nativeEvent;
   nsINativeKeyBindings *bindings = GetKeyBindings();
-  if (bindings && DOMEventToNativeKeyEvent(aKeyEvent, &nativeEvent)) {
+  if (bindings &&
+      DOMEventToNativeKeyEvent(aKeyEvent, &nativeEvent, PR_TRUE)) {
     if (bindings->KeyPress(nativeEvent, DoCommandCallback, mFrame)) {
       aKeyEvent->PreventDefault();
     }
@@ -429,7 +436,8 @@ nsTextInputListener::KeyUp(nsIDOMEvent *aKeyEvent)
 {
   nsNativeKeyEvent nativeEvent;
   nsINativeKeyBindings *bindings = GetKeyBindings();
-  if (bindings && DOMEventToNativeKeyEvent(aKeyEvent, &nativeEvent)) {
+  if (bindings &&
+      DOMEventToNativeKeyEvent(aKeyEvent, &nativeEvent, PR_FALSE)) {
     if (bindings->KeyUp(nativeEvent, DoCommandCallback, mFrame)) {
       aKeyEvent->PreventDefault();
     }