From e78d94c221325a074d45729b63c21782cf3ba5e0 Mon Sep 17 00:00:00 2001 From: "preed%sigkill.com" Date: Sat, 15 Feb 2003 08:29:26 +0000 Subject: [PATCH] Bug 192877 - State changes on bugs w/ dependancies cause "Use of uninitialized values" in BugMail.pm; r=justdave, bbaetz, a=justdave git-svn-id: svn://10.0.0.236/trunk@137844 18797224-902f-48f8-a5cc-f745e15eee43 --- mozilla/webtools/bugzilla/Bugzilla/BugMail.pm | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/mozilla/webtools/bugzilla/Bugzilla/BugMail.pm b/mozilla/webtools/bugzilla/Bugzilla/BugMail.pm index a71effcd2ad..e16a45139a5 100644 --- a/mozilla/webtools/bugzilla/Bugzilla/BugMail.pm +++ b/mozilla/webtools/bugzilla/Bugzilla/BugMail.pm @@ -773,28 +773,31 @@ sub NewProcessOnePerson ($$$$$$$$$$$$$) { my $difftext = ""; my $diffheader = ""; my $add_diff; + foreach my $diff (@diffparts) { - $add_diff = 0; - if ($diff->{'fieldname'} eq 'estimated_time' || - $diff->{'fieldname'} eq 'remaining_time' || - $diff->{'fieldname'} eq 'work_time') { + if (exists($diff->{'fieldname'}) && + ($diff->{'fieldname'} eq 'estimated_time' || + $diff->{'fieldname'} eq 'remaining_time' || + $diff->{'fieldname'} eq 'work_time')) { if (UserInGroup(Param("timetrackinggroup"), $userid)) { $add_diff = 1; } } else { $add_diff = 1; } + if ($add_diff) { - if ($diffheader ne $diff->{'header'}) { + if (exists($diff->{'header'}) && + ($diffheader ne $diff->{'header'})) { $diffheader = $diff->{'header'}; $difftext .= $diffheader; } $difftext .= $diff->{'text'}; } } - + if ($difftext eq "" && $newcomments eq "") { # Whoops, no differences! return;