From ea313db392cc0f9a0b0d4f398a13aa7e6f591087 Mon Sep 17 00:00:00 2001 From: "kestes%walrus.com" Date: Wed, 10 Mar 2004 03:42:44 +0000 Subject: [PATCH] fixed a bug where the comments were correct but the code was wrong! the code needed to call p4 something like this 'p4 changes -s submitted @2003/05/10,@now //...' but instead called it like this 'p4 changes -s @2003/05/10,@now //...' the '-s' did not have any argument which is required. This bug was found by Ken Beal . git-svn-id: svn://10.0.0.236/trunk@153810 18797224-902f-48f8-a5cc-f745e15eee43 --- .../tinderbox2/src/lib/TinderDB/VC_Perforce.pm | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/mozilla/webtools/tinderbox2/src/lib/TinderDB/VC_Perforce.pm b/mozilla/webtools/tinderbox2/src/lib/TinderDB/VC_Perforce.pm index 611deba1b7a..aba695cc418 100755 --- a/mozilla/webtools/tinderbox2/src/lib/TinderDB/VC_Perforce.pm +++ b/mozilla/webtools/tinderbox2/src/lib/TinderDB/VC_Perforce.pm @@ -22,7 +22,7 @@ # The only perforce commands this module runs are: # # 'p4 describe -s $num' -# 'p4 changes -s \@$date_str\@now $filespec' +# 'p4 changes -s submitted \@$date_str\@now $filespec' # which looks like this @@ -75,8 +75,8 @@ # Contributor(s): -# $Revision: 1.20 $ -# $Date: 2003-12-23 13:35:49 $ +# $Revision: 1.21 $ +# $Date: 2004-03-10 03:42:44 $ # $Author: kestes%walrus.com $ # $Source: /home/befator/cvs/jail/cvsroot/mozilla/webtools/tinderbox2/src/lib/TinderDB/VC_Perforce.pm,v $ # $Name: not supported by cvs2svn $ @@ -156,7 +156,7 @@ use Utils; use VCDisplay; -$VERSION = ( qw $Revision: 1.20 $ )[1]; +$VERSION = ( qw $Revision: 1.21 $ )[1]; @ISA = qw(TinderDB::BasicTxtDB); @@ -910,7 +910,7 @@ sub get_new_change_sets { $filespec = TreeData::Tree2Filespec($tree); my (@cmd) = ( - 'p4', 'changes', '-s', + 'p4', 'changes', '-s', 'submitted', '@'.$date_str.',@now', $filespec, );