From edb59db8053c93ef2b4a70262ccecd966c3fca5c Mon Sep 17 00:00:00 2001 From: "bbaetz%acm.org" Date: Sat, 28 Jun 2003 00:14:56 +0000 Subject: [PATCH] Bug 193575 - Internal server error from votes.cgi patch by bugzilla@chimpychompy.org (GavinS) r=bbaetz, a=justdave git-svn-id: svn://10.0.0.236/trunk@144237 18797224-902f-48f8-a5cc-f745e15eee43 --- mozilla/webtools/bugzilla/votes.cgi | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/mozilla/webtools/bugzilla/votes.cgi b/mozilla/webtools/bugzilla/votes.cgi index 1c7bc78166f..dfa55b91d6c 100755 --- a/mozilla/webtools/bugzilla/votes.cgi +++ b/mozilla/webtools/bugzilla/votes.cgi @@ -135,7 +135,8 @@ sub show_user { # special error handling should go away. $who || ThrowUserError("invalid_username", {name => $name}); - my $canedit = 1 if ($name eq Bugzilla->user->login); + my $canedit = 1 if (Bugzilla->user && + $name eq Bugzilla->user->login); SendSQL("LOCK TABLES bugs READ, products READ, votes WRITE, cc READ, bug_group_map READ, user_group_map READ, @@ -200,6 +201,10 @@ sub show_user { opened => IsOpenedState($status) }); } + # In case we didn't populate this earlier (i.e. an error, or + # a not logged in user viewing a users votes) + $maxvotesperbug{$product} ||= 0; + $onevoteonly = 1 if (min($::prodmaxvotes{$product}, $maxvotesperbug{$product}) == 1);