From f1030d5df282b937d977b41d5306cd4c65cc243c Mon Sep 17 00:00:00 2001 From: "smfr%smfr.org" Date: Mon, 16 Jan 2006 04:28:56 +0000 Subject: [PATCH] Camino only: Potential fix for bug 322374: fix occasional crash when clearing download items by nulling out the controller on the progress views. Patch by Nick Kreeger. git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_8_0_BRANCH@187671 18797224-902f-48f8-a5cc-f745e15eee43 --- mozilla/camino/src/download/ProgressViewController.mm | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/mozilla/camino/src/download/ProgressViewController.mm b/mozilla/camino/src/download/ProgressViewController.mm index 2e6efd765c7..19f4ae3ed53 100644 --- a/mozilla/camino/src/download/ProgressViewController.mm +++ b/mozilla/camino/src/download/ProgressViewController.mm @@ -190,6 +190,10 @@ static void FileSystemNotificationProc(FNMessage message, OptionBits flags, void mDownloader->DetachDownloadDisplay(); NS_RELEASE(mDownloader); } + + // the views might outlive us, so clear refs to us + [mCompletedView setController:nil]; + [mProgressView setController:nil]; [self unsubscribeFileSystemNotification];