Bommels05/Mozilla
Bommels05/Mozilla
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 535193 - DNS resolution in MakeSN of nsAuthSSPI causing issues for proxy servers that support NTLM auth. r=bz, a=dveditz

Browse Source 
git-svn-id: svn://10.0.0.236/trunk@259259 18797224-902f-48f8-a5cc-f745e15eee43
This commit is contained in:
sayrer%gmail.com 2009-12-21 19:00:49 +00:00
parent ac26d11851
commit f17d4b1ec0
1 changed files with 18 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
mozilla/extensions/auth/nsAuthSSPI.cpp
View File

@ -246,9 +246,24 @@ nsAuthSSPI::Init(const char *serviceName,
SEC_CHAR *package; SEC_CHAR *package;
package = (SEC_CHAR *) pTypeName[(int)mPackage]; package = (SEC_CHAR *) pTypeName[(int)mPackage];
if (mPackage == PACKAGE_TYPE_NTLM) {
// (bug 535193) For NTLM, just use the uri host, do not do canonical host lookups.
// The incoming serviceName is in the format: "protocol@hostname", SSPI expects
// "<service class>/<hostname>", so swap the '@' for a '/'.
mServiceName.Assign(serviceName);
PRInt32 index = mServiceName.FindChar('@');
if (index == kNotFound)
return NS_ERROR_UNEXPECTED;
mServiceName.Replace(index, 1, '/');
}
else {
// Kerberos requires the canonical host, MakeSN takes care of this through a
// DNS lookup.
rv = MakeSN(serviceName, mServiceName); rv = MakeSN(serviceName, mServiceName);
if (NS_FAILED(rv)) if (NS_FAILED(rv))
return rv; return rv;
}
mServiceFlags = serviceFlags; mServiceFlags = serviceFlags;