From f3100453bef6ae44f6949c01ac6c9751b5c5938b Mon Sep 17 00:00:00 2001
From: "shaver%mozilla.org"
 <shaver%mozilla.org@18797224-902f-48f8-a5cc-f745e15eee43>
Date: Wed, 17 May 2006 02:27:38 +0000
Subject: [PATCH] #55739, fix strict JS warnings, r=ben, sr=brendan

git-svn-id: svn://10.0.0.236/trunk@197076 18797224-902f-48f8-a5cc-f745e15eee43
---
 mozilla/suite/common/pref/nsPrefWindow.js    | 6 +++---
 mozilla/suite/common/pref/pref-navigator.xul | 6 ++++--
 2 files changed, 7 insertions(+), 5 deletions(-)

diff --git a/mozilla/suite/common/pref/nsPrefWindow.js b/mozilla/suite/common/pref/nsPrefWindow.js
index bc749803532..b2629176658 100644
--- a/mozilla/suite/common/pref/nsPrefWindow.js
+++ b/mozilla/suite/common/pref/nsPrefWindow.js
@@ -33,7 +33,7 @@ function initPanel ( aPrefTag )
       hPrefWindow.onpageload( aPrefTag )
     else {
       dump("*** queueing up a panel...\n");
-      queuedTag = aPrefTag;
+      window.queuedTag = aPrefTag;
     }
   } 
  
@@ -275,7 +275,7 @@ nsPrefWindow.prototype =
       onpageload: 
         function ( aPageTag )
           {
-            if( !this.wsm.dataManager.pageData[aPageTag] )
+            if( !(aPageTag in this.wsm.dataManager.pageData) )
               {
                 var prefElements = window.frames[this.contentFrame].document.getElementsByAttribute( "pref", "true" );
                 this.wsm.dataManager.pageData[aPageTag] = [];
@@ -313,7 +313,7 @@ nsPrefWindow.prototype =
               }      
             this.wsm.setPageData( aPageTag );  // do not set extra elements, accept hard coded defaults
             
-            if( window.frames[ this.contentFrame ].Startup )
+            if( 'Startup' in window.frames[ this.contentFrame ])
               {
                 window.frames[ this.contentFrame ].Startup();
               }
diff --git a/mozilla/suite/common/pref/pref-navigator.xul b/mozilla/suite/common/pref/pref-navigator.xul
index 75eb3c44ab4..878cbf71ed2 100644
--- a/mozilla/suite/common/pref/pref-navigator.xul
+++ b/mozilla/suite/common/pref/pref-navigator.xul
@@ -39,8 +39,10 @@
   </script>
   <script language="JavaScript">
   <![CDATA[
-    _elementIDs = ["startupPage", "browserStartupHomepage", "alwaysCheckWhenDropOnHome", "bookmarksButton", "goButton",
-                   "homeButton", "printButton", "searchButton" ];
+    var _elementIDs = ["startupPage", "browserStartupHomepage", 
+                       "alwaysCheckWhenDropOnHome", "bookmarksButton",
+                       "goButton", "homeButton", "printButton",
+                       "searchButton" ];
   ]]>
   </script>