Bommels05/Mozilla
Bommels05/Mozilla
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 399087 - Remove the 'mostfreqthreshold' parameter

Browse Source 
r=dkl,a=justdave


git-svn-id: svn://10.0.0.236/trunk@265295 18797224-902f-48f8-a5cc-f745e15eee43
This commit is contained in:
bzrmirror%bugzilla.org 2014-03-21 14:45:54 +00:00
parent 5490a26edb
commit f33644c0db
6 changed files with 10 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
mozilla/webtools/bugzilla/.bzrrev
View File

@ -1 +1 @@
8963 8964

2
mozilla/webtools/bugzilla/.gitrev
View File

@ -1 +1 @@
ace77744f0bc750b8976f1ad175b52ed715c8083 d6370f0638bfb1e237334e35e4e23524280cf6d2

7
mozilla/webtools/bugzilla/Bugzilla/Config/Query.pm
View File

@ -25,13 +25,6 @@ sub get_param_list {
checker => \&check_multi checker => \&check_multi
}, },
{
name => 'mostfreqthreshold',
type => 't',
default => '2',
checker => \&check_numeric
},
{ {
name => 'mybugstemplate', name => 'mybugstemplate',
type => 't', type => 't',

6
mozilla/webtools/bugzilla/Bugzilla/Constants.pm
View File

@ -187,6 +187,8 @@ use Memoize;
AUDIT_CREATE AUDIT_CREATE
AUDIT_REMOVE AUDIT_REMOVE
MOST_FREQUENT_THRESHOLD
); );
@Bugzilla::Constants::EXPORT_OK = qw(contenttypes); @Bugzilla::Constants::EXPORT_OK = qw(contenttypes);
@ -616,6 +618,10 @@ use constant PRIVILEGES_REQUIRED_EMPOWERED => 3;
use constant AUDIT_CREATE => '__create__'; use constant AUDIT_CREATE => '__create__';
use constant AUDIT_REMOVE => '__remove__'; use constant AUDIT_REMOVE => '__remove__';
# The minimum number of duplicates a bug needs to show up
# on the "Most frequently reported bugs" page.
use constant MOST_FREQUENT_THRESHOLD => 2;
sub bz_locations { sub bz_locations {
# Force memoize() to re-compute data per project, to avoid # Force memoize() to re-compute data per project, to avoid
# sharing the same data across different installations. # sharing the same data across different installations.

5
mozilla/webtools/bugzilla/duplicates.cgi
View File

@ -172,10 +172,9 @@ my %since_dups = @{$dbh->selectcol_arrayref(
$reso_field_id, $changedsince)}; $reso_field_id, $changedsince)};
add_indirect_dups(\%since_dups, \%dupe_relation); add_indirect_dups(\%since_dups, \%dupe_relation);
# Enforce the mostfreqthreshold parameter and the "bug_id" cgi param. # Enforce the MOST_FREQUENT_THRESHOLD constant and the "bug_id" cgi param.
my $mostfreq = Bugzilla->params->{'mostfreqthreshold'};
foreach my $id (keys %total_dups) { foreach my $id (keys %total_dups) {
if ($total_dups{$id} < $mostfreq) { if ($total_dups{$id} < MOST_FREQUENT_THRESHOLD) {
delete $total_dups{$id}; delete $total_dups{$id};
next; next;
} }

5
mozilla/webtools/bugzilla/template/en/default/admin/params/query.html.tmpl
View File

@ -26,11 +26,6 @@
</li> </li>
</ul>", </ul>",
mostfreqthreshold => "The minimum number of duplicates $terms.abug needs to show up on the " _
"<a href=\"duplicates.cgi\">most frequently reported $terms.bugs page</a>. " _
"If you have a large database and this page takes a long time to " _
"load, try increasing this number.",
mybugstemplate => "This is the URL to use to bring up a simple 'all of my $terms.bugs' " _ mybugstemplate => "This is the URL to use to bring up a simple 'all of my $terms.bugs' " _
"list for a user. %userid% will get replaced with the login name of a user. " _ "list for a user. %userid% will get replaced with the login name of a user. " _
"Special characters must be URL-encoded.", "Special characters must be URL-encoded.",