From f58b8fddb7139ead61ea14c7cdfbb34ef2fe7643 Mon Sep 17 00:00:00 2001 From: "mozilla.mano%sent.com" Date: Mon, 23 Apr 2007 23:30:11 +0000 Subject: [PATCH] Bug 378470 - refreshVisibleSection fails to update viewIndex properly. patch from onemen.one@gmail.com, r=me. git-svn-id: svn://10.0.0.236/trunk@224910 18797224-902f-48f8-a5cc-f745e15eee43 --- mozilla/browser/components/places/content/treeView.js | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/mozilla/browser/components/places/content/treeView.js b/mozilla/browser/components/places/content/treeView.js index 059475574a9..3b806644a1e 100644 --- a/mozilla/browser/components/places/content/treeView.js +++ b/mozilla/browser/components/places/content/treeView.js @@ -318,7 +318,7 @@ PlacesTreeView.prototype = { replaceCount-=1; // Mark the removees as invisible - for (var i = startReplacement; i < replaceCount; i ++) + for (var i = 0; i < replaceCount; i ++) this._visibleElements[startReplacement + i].viewIndex = -1; // Building the new list will set the new elements' visible indices. @@ -735,7 +735,7 @@ PlacesTreeView.prototype = { set collapseDuplicates(val) { if (this._collapseDuplicates == val) - return; // no change; + return val; // no change; this._collapseDuplicates = val; if (this._tree && this._result) @@ -916,8 +916,7 @@ PlacesTreeView.prototype = { // For consistency, we always return a favicon for non-containers, // even if it is just the default one. var icon = node.icon || PlacesUtils.favicons.defaultFavicon; - if (icon) - return icon.spec; + return icon ? icon.spec : ""; }, getProgressMode: function(aRow, aColumn) { },