Bommels05/Mozilla
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fixes all over for E3 test results - gc + ECMA edge cases.

Browse Source 
git-svn-id: svn://10.0.0.236/trunk@140790 18797224-902f-48f8-a5cc-f745e15eee43
This commit is contained in:
rogerl%netscape.com
2003-04-07 07:24:17 +00:00
parent 7bcfb95f5b
commit f9a7202f3e
13 changed files with 260 additions and 138 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
mozilla/js2/src/js2array.cpp
View File

@@ -258,13 +258,14 @@ static js2val Array_join(JS2Metadata *meta, const js2val thisValue, js2val *argv
JS2Object *thisObj = JS2VAL_TO_OBJECT(thatValue);
uint32 length = getLength(meta, thisObj);
const String *separator;
const String *separator = NULL;
DEFINE_ROOTKEEPER(rk1, separator);
if ((argc == 0) || JS2VAL_IS_UNDEFINED(argv[0]))
separator = new String(widenCString(","));
separator = meta->engine->allocStringPtr(",");
else
separator = meta->toString(argv[0]);
String *S = new String();
String *S = new String(); // not engine allocated, doesn't need rooting
JS2Class *c = meta->objectType(thisObj);
for (uint32 k = 0; k < length; k++) {
@@ -537,7 +538,9 @@ static int32 sort_compare(js2val *a, js2val *b, CompareArgs *arg)
}
else {
const String *astr = meta->toString(av);
DEFINE_ROOTKEEPER(rk1, astr);
const String *bstr = meta->toString(bv);
DEFINE_ROOTKEEPER(rk2, bstr);
result = astr->compare(*bstr);
}
return result;